Repository navigation
[CI|Release] Run the artifact actions on Node 24 - #2166
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughBuild and release workflows now use newer GitHub Actions artifact upload and download versions. Artifact names, paths, and retention settings remain unchanged where specified. ChangesBuild and release artifacts
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This updates CI and release workflows to artifact actions that run on Node 24. No user-facing behavior changes, and the merge risk is minimal. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
actions/upload-artifact@v4andactions/download-artifact@v4declare Node 20, so GitHub forces them onto Node 24 and warns on every Desktop Release run. They were the only actions left on Node 20 in any workflow.release-local.yml,build-sdcpp.ymlandbuild-audiocpp.ymlmove toupload-artifact@v7anddownload-artifact@v8, the versionsdocker-build.ymlanddocker-tests.ymlalready use.Follows #2162
High-level PR Summary
This Pull Request updates GitHub Actions artifact handling (
upload-artifactanddownload-artifact) to their latest versions across three workflow files to address Node 20 deprecation warnings. The workflows are upgraded from v4 to v7/v8 respectively, which use Node 24 instead of the deprecated Node 20. This is a maintenance update with no functional changes to the artifact upload/download behavior.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
.github/workflows/build-audiocpp.yml.github/workflows/build-sdcpp.yml.github/workflows/release-local.ymlSummary by CodeRabbit