Skip to content

[CI|Release] Run the artifact actions on Node 24 - #2166

Merged
CREDO23 merged 1 commit into
devfrom
fix/release-artifact-actions-node-24
Oct 3, 2026
Merged

CREDO23 merged 1 commit into
devfrom
fix/release-artifact-actions-node-24

Conversation

@CREDO23

@CREDO23 CREDO23 commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • actions/upload-artifact@v4 and actions/download-artifact@v4 declare Node 20, so GitHub forces them onto Node 24 and warns on every Desktop Release run. They were the only actions left on Node 20 in any workflow.
  • release-local.yml, build-sdcpp.yml and build-audiocpp.yml move to upload-artifact@v7 and download-artifact@v8, the versions docker-build.yml and docker-tests.yml already use.
  • Nothing these workflows pass changes meaning: uploads still zip by default, downloads are by name, and a download whose hash does not match now fails instead of warning.

Follows #2162

High-level PR Summary

This Pull Request updates GitHub Actions artifact handling (upload-artifact and download-artifact) to their latest versions across three workflow files to address Node 20 deprecation warnings. The workflows are upgraded from v4 to v7/v8 respectively, which use Node 24 instead of the deprecated Node 20. This is a maintenance update with no functional changes to the artifact upload/download behavior.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 .github/workflows/build-audiocpp.yml
2 .github/workflows/build-sdcpp.yml
3 .github/workflows/release-local.yml

Need help? Join our Discord

Summary by CodeRabbit

  • Chores
    • Updated release build workflows to use newer artifact upload and download actions. Artifact names, locations, and retention periods remain unchanged, so the change does not alter the artifacts provided or how long they are retained.

@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
surf-sense-frontend Ready Ready Preview Oct 3, 2026 6:11am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: MODSetter/SurfSense/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0fabb7a0-f198-428d-9dce-76f1d088b238
📥 Commits

Reviewing files that changed from the base of the PR and between 3b96279 and 1930048.

📒 Files selected for processing (3)
  • .github/workflows/build-audiocpp.yml
  • .github/workflows/build-sdcpp.yml
  • .github/workflows/release-local.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Build and release workflows now use newer GitHub Actions artifact upload and download versions. Artifact names, paths, and retention settings remain unchanged where specified.

Changes

Build and release artifacts

Layer / File(s) Summary
Build artifact uploads
.github/workflows/build-audiocpp.yml, .github/workflows/build-sdcpp.yml
Both build workflows now use actions/upload-artifact@v7.
Release artifact transfers
.github/workflows/release-local.yml
The release workflow now uses actions/download-artifact@v8 for build artifacts and actions/upload-artifact@v7 for installers.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 19300

This updates CI and release workflows to artifact actions that run on Node 24. No user-facing behavior changes, and the merge risk is minimal.

Architecture Summary

Architecture risk: 🔵 Low · up to 19300

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/build-audiocpp.yml: The artifact upload step now uses actions/upload-artifact@v7 instead of @v4.
  • observed — Modified behavior in .github/workflows/build-sdcpp.yml: The artifact upload step now uses actions/upload-artifact@v7 instead of @v4.
  • observed — Modified behavior in .github/workflows/release-local.yml: The audio.cpp artifact download step now uses actions/download-artifact@v8 instead of @v4.
  • observed — Modified behavior in .github/workflows/release-local.yml: The sd.cpp artifact download step now uses actions/download-artifact@v8 instead of @v4.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating the artifact actions so they run on Node 24.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CREDO23
CREDO23 merged commit 0847e12 into dev Oct 3, 2026
28 of 29 checks passed

This branch was successfully deployed

1 active deployment
Preview — 1930048d Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant