Repository navigation
docs(proposals): make backend/ the one backend for the plugins and the license - #2335
Merged
Merged
Conversation
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the legacy-split proposal:
plugins/moves tobackend/plugins/, and the license portal and the mailer port intobackend/license/andbackend/mailer/beside it. One process, assembled inbackend/server/, serves both. It lists what the move must change with it (Coolify's two builds, the BSL license path, workflows, links) and adds a CI job that builds the images.Why
The license belongs to the desktop app, not to the plugins, so it should not live under
plugins/. Onebackend/with one folder per module replacessurfsense_backend.Fixes # (none; related to #2100)
How to test
python scripts/check_docs.py docs/proposals/legacy-split/README.mdHigh-level PR Summary
This proposal consolidates the backend architecture by moving
plugins/intobackend/plugins/and relocating the license portal and mailer fromsurfsense_backendintobackend/license/andbackend/mailer/. The change creates a single unified backend process served frombackend/server/that handles both plugins and licensing, replacing the previous split betweensurfsense_backendand the plugin host. The document details the migration strategy, including necessary changes to Coolify builds, CI workflows, file paths, documentation links, and deployment procedures, while also outlining the creation of a frozenlegacybranch for deprecated code.⏱️ Estimated Review Time: 15-30 minutes
💡 Review Order Suggestion
docs/proposals/legacy-split/README.mdSummary by CodeRabbit
backend/, with the marketing site underhomepage/.devandmain.