Skip to content

ci(legacy-split): remove the self-hosted image workflows from dev - #2340

Merged
AnishSarkar22 merged 1 commit into
MODSetter:devfrom
AnishSarkar22:ci/drop-legacy-docker-build
Oct 24, 2026
Merged

AnishSarkar22 merged 1 commit into
MODSetter:devfrom
AnishSarkar22:ci/drop-legacy-docker-build

Conversation

@AnishSarkar22

@AnishSarkar22 AnishSarkar22 commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

What

Removes the self-hosted image workflows from dev, now that the self-hosted stack builds, tests and releases from the legacy branch (#2339, released as legacy-v0.0.41).

  • Deletes .github/workflows/docker-build.yml and .github/workflows/docker-tests.yml.
  • Drops the paragraph in surfsense_local/RELEASE.md about the image build that the release merge started on main.
  • Points the docs' links to docker-build.yml (ADR 0035, the Docker proposal and its GPU page) at the file on the legacy branch, and updates the comments and CONTRIBUTING.md lines that named either workflow.

Why

docker-build.yml on main publishes latest and 0.0.40 for surfsense-backend, surfsense-web and surfsense-sandbox, and every desktop release merge into main starts it, because the version bump touches surfsense_backend and surfsense_web. The next desktop release would have replaced the 0.0.41 images released from legacy with images built from main, and Watchtower would have rolled them out to every self-hosted install.

Once this reaches main, the release merge commit no longer has the workflow, so nothing publishes. surfsense_backend and surfsense_web stay on dev until the cutover and the homepage split; their tests run on legacy, where self-hosted fixes go.

Fixes # (none; part of the legacy-split proposal)

How to test

  • python3 scripts/check_docs.py reports 0 problems.
  • No workflow on this branch builds or pushes ghcr.io/modsetter/surfsense-backend, surfsense-web or surfsense-sandbox.
  • After the next release merge into main, no "Build and Push Docker Images" run starts on main.

High-level PR Summary

Removes self-hosted Docker image build workflows from the dev branch, now that the self-hosted stack builds and releases from the legacy branch. This prevents the next desktop release from inadvertently replacing legacy images (v0.0.41) with images built from main. Updates documentation links, workflow comments, and release procedures to reflect that surfsense_backend and surfsense_web now live on the legacy branch while desktop development continues on dev/main.

⏱️ Estimated Review Time: 15-30 minutes

💡 Review Order Suggestion
Order File Path
1 .github/workflows/docker-build.yml
2 .github/workflows/docker-tests.yml
3 surfsense_local/RELEASE.md
4 CONTRIBUTING.md
5 .github/workflows/code-quality.yml
6 .github/workflows/desktop-tests.yml
7 .github/workflows/release-channels.yml
8 docs/adr/0035-docker-compose-runs-the-desktop-stack.md
9 docs/contracts/README.md
10 docs/proposals/docker/README.md
11 docs/proposals/docker/gpu.md

Need help? Join our Discord

docker-build.yml on main published `latest` and `0.0.40` for the
self-hosted images, and every desktop release merge started it, so the
next one would have replaced the 0.0.41 images released from `legacy`.
The self-hosted stack now builds, tests and releases from the `legacy`
branch only.

- Delete docker-build.yml and docker-tests.yml.
- Drop the release-runbook paragraph about the image build on main.
- Point the docs' links to docker-build.yml at the legacy branch, and
  update the comments and CONTRIBUTING lines that named either workflow.
@vercel

vercel Bot commented Oct 24, 2026

Copy link
Copy Markdown

@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AnishSarkar22
AnishSarkar22 merged commit 261edd6 into MODSetter:dev Oct 24, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant