Repository navigation
ci(legacy-split): remove the self-hosted image workflows from dev - #2340
Merged
AnishSarkar22 merged 1 commit intoOct 24, 2026
Merged
Conversation
docker-build.yml on main published `latest` and `0.0.40` for the self-hosted images, and every desktop release merge started it, so the next one would have replaced the 0.0.41 images released from `legacy`. The self-hosted stack now builds, tests and releases from the `legacy` branch only. - Delete docker-build.yml and docker-tests.yml. - Drop the release-runbook paragraph about the image build on main. - Point the docs' links to docker-build.yml at the legacy branch, and update the comments and CONTRIBUTING lines that named either workflow.
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the self-hosted image workflows from
dev, now that the self-hosted stack builds, tests and releases from thelegacybranch (#2339, released aslegacy-v0.0.41)..github/workflows/docker-build.ymland.github/workflows/docker-tests.yml.surfsense_local/RELEASE.mdabout the image build that the release merge started onmain.docker-build.yml(ADR 0035, the Docker proposal and its GPU page) at the file on thelegacybranch, and updates the comments andCONTRIBUTING.mdlines that named either workflow.Why
docker-build.ymlonmainpublisheslatestand0.0.40forsurfsense-backend,surfsense-webandsurfsense-sandbox, and every desktop release merge intomainstarts it, because the version bump touchessurfsense_backendandsurfsense_web. The next desktop release would have replaced the 0.0.41 images released fromlegacywith images built frommain, and Watchtower would have rolled them out to every self-hosted install.Once this reaches
main, the release merge commit no longer has the workflow, so nothing publishes.surfsense_backendandsurfsense_webstay ondevuntil the cutover and the homepage split; their tests run onlegacy, where self-hosted fixes go.Fixes # (none; part of the legacy-split proposal)
How to test
python3 scripts/check_docs.pyreports 0 problems.ghcr.io/modsetter/surfsense-backend,surfsense-weborsurfsense-sandbox.main, no "Build and Push Docker Images" run starts onmain.High-level PR Summary
Removes self-hosted Docker image build workflows from the
devbranch, now that the self-hosted stack builds and releases from thelegacybranch. This prevents the next desktop release from inadvertently replacing legacy images (v0.0.41) with images built frommain. Updates documentation links, workflow comments, and release procedures to reflect thatsurfsense_backendandsurfsense_webnow live on thelegacybranch while desktop development continues ondev/main.⏱️ Estimated Review Time: 15-30 minutes
💡 Review Order Suggestion
.github/workflows/docker-build.yml.github/workflows/docker-tests.ymlsurfsense_local/RELEASE.mdCONTRIBUTING.md.github/workflows/code-quality.yml.github/workflows/desktop-tests.yml.github/workflows/release-channels.ymldocs/adr/0035-docker-compose-runs-the-desktop-stack.mddocs/contracts/README.mddocs/proposals/docker/README.mddocs/proposals/docker/gpu.md