Repository navigation
feat(desktop): privacy choices as an onboarding step, and updates in the title bar - #2347
Merged
AnishSarkar22 merged 5 commits intoOct 25, 2026
Merged
Conversation
…hoices Privacy choices is now onboarding's first step, counted in the progress bar and shown every time onboarding runs, with earlier answers chosen. Back from the first model step returns to it. Each choice is one line, with the full description and every host behind an info icon and a link to the exact request or report. Yes and No are one control whose chosen half is filled. Settings › About uses the same text and info icon.
…tle bar While an update downloads, a ring around a pill beside the right-panel toggle fills with the percentage electron-updater reports, sent once per whole percent. Once ready, the pill fills and restarts into the update on click. On hover or focus it widens to show "Downloading 64%" or "Update". The sidebar no longer shows updates. Check for Updates… in the macOS menu reports up to date or a failed check in a toast, since Settings may be closed.
|
@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The privacy step was easy to skip past and its rows were walls of text. Update status was split between the sidebar and the title bar, and a download gave no feedback.
Fixes #
How to test
cd surfsense_local/frontend && pnpm testandcd surfsense_local/electron && pnpm test.High-level PR Summary
This PR restructures the privacy choices onboarding flow to be the first numbered step and consolidates update status display in the title bar with a downloadable progress indicator and restart button, removing update information from the sidebar.
⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
docs/architecture/updates.mddocs/architecture/usage-statistics.mdsurfsense_local/frontend/src/features/updates/title-bar-update.tsxsurfsense_local/frontend/src/features/updates/download-ring.tsxsurfsense_local/frontend/src/features/updates/menu-update-check.tsxsurfsense_local/frontend/src/features/updates/update-settings.tsxsurfsense_local/frontend/src/features/dashboard/dashboard-page.tsxsurfsense_local/frontend/src/features/dashboard/sidebar-footer.tsxsurfsense_local/frontend/src/features/onboarding/onboarding-page.tsxsurfsense_local/frontend/src/features/onboarding/privacy-step/privacy-step.tsxsurfsense_local/frontend/src/features/onboarding/privacy-step/privacy-choice-row.tsxsurfsense_local/frontend/src/features/privacy-choices/choice-text.tssurfsense_local/frontend/src/features/privacy-choices/details-tooltip.tsxsurfsense_local/frontend/src/features/privacy-choices/usage-statistics-settings.tsxsurfsense_local/frontend/src/features/about/data-folder.tsxsurfsense_local/electron/src/main/updater.tssurfsense_local/frontend/src/features/updates/use-check-for-updates.tssurfsense_local/frontend/src/lib/api.tssurfsense_local/frontend/src/components/ui/icons.tsxsurfsense_local/frontend/src/features/privacy-choices/stub-privacy-bridge.tssurfsense_local/electron/src/main/updater.test.tssurfsense_local/frontend/src/features/updates/title-bar-update.test.tsxsurfsense_local/frontend/src/features/updates/menu-update-check.test.tsxsurfsense_local/frontend/src/features/updates/update-settings.test.tsxsurfsense_local/frontend/src/features/dashboard/sidebar-footer.test.tsxsurfsense_local/frontend/src/features/onboarding/onboarding-page.test.tsxsurfsense_local/frontend/src/features/privacy-choices/usage-statistics-settings.test.tsxsurfsense_local/frontend/translations/en.jsonsurfsense_local/frontend/translations/de.jsonsurfsense_local/frontend/translations/es.jsonsurfsense_local/frontend/translations/fr.jsonsurfsense_local/frontend/translations/hi.jsonsurfsense_local/frontend/translations/ja.jsonsurfsense_local/frontend/translations/ko.jsonsurfsense_local/frontend/translations/pt-BR.jsonsurfsense_local/frontend/translations/ru.jsonsurfsense_local/frontend/translations/zh-CN.json