Repository navigation
Conversation
…the connection electron-builder notarizes through @electron/notarize 2.5.0, which wraps the staple in promise-retry with `retries: 3`. promise-retry retries only when the callback calls the retry it is handed, and that callback never does, so the first failed staple fails the build. v2.2.5's Mac leg did just that: notarization succeeded, then stapler lost its connection to api.apple-cloudkit.com (NSURLErrorDomain -1005, stapler error 68). The patch retries a failed staple five times, after 10, 20, 40, 60 and 60 s, and prints each failure. The waits also cover a ticket that has not reached the ticket service yet.
fix(release): retry the Mac staple when Apple's ticket service drops the connection
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second release pull request for 2.2.5. It adds one fix on top of #2358.
v2.2.5's first Desktop Release run (40415639797) failed on the macOS leg:
staplerthen lost its connection to Apple's ticket service.@electron/notarize2.5.0 never retries a failed staple, so that one error failed the build.#2361 patches the retry so it works.
Changes since
main: only #2361 (the pnpm patch, itspnpm-workspace.yamlentry and the lockfile hash). The app's code and version are unchanged.After merging:
v2.2.5tag onto this merge. This starts a full Desktop Release run, which re-uploads every asset on the same draft.buildlegs,legacy-update-bridgeandrelease-extrasare green.High-level PR Summary
This is a release pull request for desktop version 2.2.5 that addresses a build failure in the macOS release pipeline. The previous release attempt succeeded in notarizing the app but failed when the
staplercommand lost connection to Apple's ticket service. Since@electron/notarize2.5.0 doesn't retry failed staple operations, the build failed. This PR patches@electron/notarizeto implement proper retry logic with exponential backoff (10s, 20s, 40s, then 60s twice) and increases retry attempts from 3 to 5, ensuring the staple operation can recover from transient network failures.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_local/electron/pnpm-workspace.yamlsurfsense_local/electron/patches/@electron__notarize@2.5.0.patchsurfsense_local/electron/pnpm-lock.yaml