Skip to content

Allow passing auth param to create client cert session #245

Closed

Description

@AMaciaga

In my project I need test that uses session with both certificate and auth. Could you modify Create Client Cert Session keyword to accept auth parameter instead of setting it to None by default? Or create new keyword that allows that?

Activity

  1. self-assigned this
    on Nov 13, 2019
  2. added this to the 0.6 milestone on Nov 13, 2019
  3. AMaciaga commented on Nov 18, 2019

    @AMaciaga
    Author

    Could you tell me, when you plan to release correction for this issue and is there any demand for specific python version.

  4. lucagiove commented on Nov 20, 2019

    @lucagiove
    Member

    As soon as I've some spare time :) I'll work on it and no there are no needs for specific python versions.

  5. modified the milestones: 0.6, 0.7 on Apr 17, 2020
  6. modified the milestones: 0.7, 0.8 on Nov 12, 2020
  7. modified the milestones: 0.8, 0.9 on Apr 15, 2021
  8. robinmatz commented on Dec 26, 2021

    @robinmatz
    Contributor

    I would like to contribute to this issue. What I need to know is, should the auth be of HTTP Basic auth? Or should it be like in Create Custom Session where any auth type is accepted, but user has to take care of creating the auth object?

  9. lucagiove commented on Dec 26, 2021

    @lucagiove
    Member

    I would like to contribute to this issue. What I need to know is, should the auth be of HTTP Basic auth? Or should it be like in Create Custom Session where any auth type is accepted, but user has to take care of creating the auth object?

    I think "Create Client Cert Session" should have also auth parameter since all the other keywords have it should be basic auth like the others.
    The only problem is that it would be a breaking change.

  10. modified the milestones: 0.9, 1.0 on Jan 29, 2022
  11. lucagiove commented on May 17, 2022

    @lucagiove
    Member

    @robinmatz I published a 1.0a1 version with your changes, I hope you can use the library now.
    I'll introduce further breaking changes later on this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions