Skip to content

Support sending arrays in query string and request body - #220

Closed
conradolega wants to merge 1 commit into
MarketSquare:masterfrom
conradolega:support-arrays
Closed

conradolega wants to merge 1 commit into
MarketSquare:masterfrom
conradolega:support-arrays

Conversation

@conradolega

@conradolega conradolega commented Feb 11, 2019 •

Copy link
Copy Markdown

Before, if an array foo = ['bar', 'baz'] was passed to a request as part of the params or data, it would be encoded as foo=%5Bbar,baz%5D, which will be received by the server as the string "['bar','baz']"'. This fixes the URL encoding of the request so that the array will be passed as foo=bar&foo=baz.

@conradolega

Copy link
Copy Markdown
Author

The build failed as we have to update the CI job - once #221 has been merged, I will rebase this PR.

@lucagiove

Copy link
Copy Markdown
Member

Hi could you have a look at #234 I was thinking that maybe we're encoding twice the data maybe requests original library already properly does the job.
What do you think?

@lucagiove

Copy link
Copy Markdown
Member

I cannot reproduce the problem with a flask backend it probably more related to the backend.
See my comments in #234

@lucagiove lucagiove closed this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants