Skip to content

🔧 SCARA / TPARA limits contain the home position - #1214

Open
thinkyhead wants to merge 1 commit into
MarlinFirmware:import-2.1.xfrom
thinkyhead:pr-28690
Open

thinkyhead wants to merge 1 commit into
MarlinFirmware:import-2.1.xfrom
thinkyhead:pr-28690

Conversation

@thinkyhead

Copy link
Copy Markdown
Member

Description

Companion to MarlinFirmware/Marlin#28690, which adds a compile-time check that the SCARA/TPARA home position lies inside X/Y_MIN_POS..X/Y_MAX_POS.

The stock examples keep X/Y_MIN_POS 0, but their home position is computed from the home angles and is outside that range:

Example Home position Change
SCARA/Morgan X 47.9, Y -56.0 Y_MIN_POS -60
SCARA/MP_SCARA X 187.1, Y -188.1 Y_MIN_POS -190
TPARA/AXEL_TPARA X -71.25 X_MIN_POS -80

Nothing else changes: the bed is still 0..X/Y_BED_SIZE.

Requirements

Marlin#28690. Until it merges these limits are harmless; the examples build with or without it.

Benefits

The examples keep building once the check lands.

Testing. I did not build against these files directly. The same three limit values were applied as overrides to the Marlin CI configs (mega2560ext config-08 and config-09, mega2560 config-05), and those build with the new check on every commit of #28690.

Related Issues

MarlinFirmware/Marlin#28690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant