Bundle applet-mdflash.bin into executable - #61
Merged
Conversation
zvecr
changed the title
zvecr
added a commit
to zvecr/mdloader
that referenced
this pull request
Sep 29, 2021
Bundle applet-mdflash.bin into executable
zvecr
marked this pull request as draft
September 29, 2021 21:54
|
I solved this for the Homebrew formula with the following patch: https://github.com/qmk/homebrew-qmk/blob/master/Patch/mdloader-applet-path.patch |
Collaborator
Author
This PR should remove the need for such patches. |
zvecr
marked this pull request as ready for review
September 30, 2021 12:58
Merged
zvecr
force-pushed
the
feature/bundle_applet
branch
from
October 1, 2021 00:24
2b5c628 to
88ab416
Compare
This was referenced Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a few of the flashing/packaging issues where the applet is assumed to be in the current working directory.
Introduces https://github.com/graphitemaster/incbin as a dependency, which should be a compatible licence. This was due to objcopy/
-Wl,--format=binary -Wl,applet-mdflash.binnot functioning on macos, and was proving to be a bit of a pain to work generically.Fixes #21 (and maybe a few others).
Testing: