You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Shadow Depth not applied to DrawerHost in both modes #2804
In 4.4 version there are no problems with DrawerHost in Standard mode. Version 4.5 has bug when Modal mode has a fixed shadow, and Standard mode didn't have any shadows. This bug can also be reproduced in nightly build.
On screenshots you can see that there are no matter what ShadowDepth is picked. Can it be fixed any way without waiting for a patch?
changed the title [-]Shadow Depth not applied to DrawerHost in Standard mode[/-][+]Shadow Depth not applied to DrawerHost in both modes[/+]on Aug 5, 2022
@DarkPro1337 I think you're experiencing these issues because ShadowAssist.ShadowDepth has been replaced with ElevationAssist.Elevation in PR #2786.
To avoid breaking existing code, the ShadowAssist.ShadowDepth is simply obsoleted for now (to be removed in version 5.0.0), and it has been modified to apply a "corresponding" ElevationAssist.Elevationwhen applied.
Since these attached properties are not inherited by child elements, setting them via Snoop requires that you set them on the closest DrawerHost visual ancestor. If I change ShadowAssist.ShadowDepth on the closest DrawerHost in Snoop, the corresponding ElevationAssist.Elevation is updated accordingly and the UI changes:
If you're setting a custom shadow depth in your project, you should probably change it to set the ElevationAssist.Elevation instead.
This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.
Activity
[-]Shadow Depth not applied to DrawerHost in Standard mode[/-][+]Shadow Depth not applied to DrawerHost in both modes[/+]nicolaihenriksen commentedon Jan 13, 2023
@DarkPro1337 I think you're experiencing these issues because
ShadowAssist.ShadowDepthhas been replaced withElevationAssist.Elevationin PR #2786.To avoid breaking existing code, the
ShadowAssist.ShadowDepthis simply obsoleted for now (to be removed in version 5.0.0), and it has been modified to apply a "corresponding"ElevationAssist.Elevationwhen applied.Since these attached properties are not inherited by child elements, setting them via Snoop requires that you set them on the closest
DrawerHostvisual ancestor. If I changeShadowAssist.ShadowDepthon the closestDrawerHostin Snoop, the correspondingElevationAssist.Elevationis updated accordingly and the UI changes:If you're setting a custom shadow depth in your project, you should probably change it to set the
ElevationAssist.Elevationinstead.github-actions commentedon Apr 22, 2023
This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.
github-actions commentedon May 7, 2023
This issue was closed because it has been stalled for 14 days with no activity.