Skip to content

Shadow Depth not applied to DrawerHost in both modes #2804

Closed as not planned
Closed as not planned

Description

@DarkPro1337

Bug explanation

In 4.4 version there are no problems with DrawerHost in Standard mode. Version 4.5 has bug when Modal mode has a fixed shadow, and Standard mode didn't have any shadows. This bug can also be reproduced in nightly build.
On screenshots you can see that there are no matter what ShadowDepth is picked. Can it be fixed any way without waiting for a patch?
MaterialDesignDemo_DvDpHzfYAi
image

Version

4.5.0

Activity

  1. changed the title [-]Shadow Depth not applied to DrawerHost in Standard mode[/-] [+]Shadow Depth not applied to DrawerHost in both modes[/+] on Aug 5, 2022
  2. nicolaihenriksen commented on Jan 13, 2023

    @nicolaihenriksen
    Contributor

    @DarkPro1337 I think you're experiencing these issues because ShadowAssist.ShadowDepth has been replaced with ElevationAssist.Elevation in PR #2786.

    To avoid breaking existing code, the ShadowAssist.ShadowDepth is simply obsoleted for now (to be removed in version 5.0.0), and it has been modified to apply a "corresponding" ElevationAssist.Elevation when applied.

    Since these attached properties are not inherited by child elements, setting them via Snoop requires that you set them on the closest DrawerHost visual ancestor. If I change ShadowAssist.ShadowDepth on the closest DrawerHost in Snoop, the corresponding ElevationAssist.Elevation is updated accordingly and the UI changes:

    Elevation


    If you're setting a custom shadow depth in your project, you should probably change it to set the ElevationAssist.Elevation instead.

    image

  3. added
    Waiting on feedbackAdditional information is needed. Stale items with this label may be closed.
    and removed
    evaluation requiredItems is pending review or evaluation by the team
    on Jan 13, 2023
  4. github-actions commented on Apr 22, 2023

    @github-actions
    Contributor

    This issue is marked stale because it has been open 30 days with no activity. Remove stale label or update the issue, otherwise it will be closed in 14 days.

  5. added
    StaleIssues and PRs that have not had activity for a while are marked with this label.
    on Apr 22, 2023
  6. github-actions commented on May 7, 2023

    @github-actions
    Contributor

    This issue was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    StaleIssues and PRs that have not had activity for a while are marked with this label.Waiting on feedbackAdditional information is needed. Stale items with this label may be closed.bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions