Skip to content

DialogHost background fade out is to slow when using MaterialDesignEmbeddedDialogHost and TransitionAssist.DisableTransitions="True" #2826

Closed

Description

@poralcode

Bug explanation

I'd like to disable the transition of the DialogHost and at the same time, use the style MaterialDesignEmbeddedDialogHost.

<md:DialogHost
                Grid.Row="1"
                md:TransitionAssist.DisableTransitions="True"
                Identifier="ContainerDialogHost"
                SnackbarMessageQueue="{Binding ElementName=MySnackbar, Path=MessageQueue}"
                Style="{StaticResource MaterialDesignEmbeddedDialogHost}">

</md:DialogHost>

Together with md:TransitionAssist.DisableTransitions="True" and MaterialDesignEmbeddedDialogHost everything Is fast when opening the dialog. However, upon closing it, I noticed that the Background is slowly fading out. Are there any other settings I am missing?

Version

using version 4.5.0

Activity

  1. Erapchu commented on Aug 24, 2022

    @Erapchu
    Contributor

    I'm just using that style

    https://github.com/Erapchu/SinglePass.WPF/blob/develop/SinglePass.WPF/Themes/DialogHostTemplates.xaml

    You can just remove PART_ContentCoverGrid and animations for it if you want the same effect but without that bug

  2. Erapchu commented on Aug 24, 2022

    @Erapchu
    Contributor
  3. poralcode commented on Aug 24, 2022

    @poralcode
    Author

    I'm just using that style

    https://github.com/Erapchu/SinglePass.WPF/blob/develop/SinglePass.WPF/Themes/DialogHostTemplates.xaml

    You can just remove PART_ContentCoverGrid and animations for it if you want the same effect but without that bug

    Commenting

    <DoubleAnimation
          Storyboard.TargetName="PART_ContentCoverGrid"
          Storyboard.TargetProperty="(UIElement.Opacity)"
          To="0" />
    

    in <VisualState x:Name="Closed"> at the bottom of the style is enough to disabled the animation.

  4. Erapchu commented on Aug 24, 2022

    @Erapchu
    Contributor

    Of course I just want to leave it for future changes

  5. added a commit that references this issue on Aug 30, 2022
  6. nicolaihenriksen commented on Sep 23, 2022

    @nicolaihenriksen
    Contributor

    Closing this issue because I believe it was included in the 4.6.0 release; see PR #2829.

  7. added this to the 4.6.0 milestone on Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions