Repository navigation
Overhaul CLI coder terminal UI/UX and interactive approval workflow - #2448
Merged
Merged
Conversation
Matlan1
added
full-ci
… for the session; @file reads through read_file and honours /scope Answering 'a' used to switch on session-wide auto-approve, so one 'a' on a file write silently approved every later shell command, push and network call. It now allows only the tool it was asked about, or the exact command for a shell tool, and never waives a shell-guard verdict, a loosely formatted call or a configured always_confirm. @file attachments go through read_file (same confinement, notebook rendering and truncation the model's own read gets) and skip paths outside the session's /scope. Also fixes the ruff findings (B023, UP037) and stops printing a static 'Thinking...' line next to the live spinner on a terminal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y; plain /compact hint Typing anything other than y/a/f/n at an approval prompt used to count as a silent "no", so an instruction typed there was lost. It is now a rejection that carries the typed text back to the agent. The context-full warning printed literal "[bold]" tags because warnings are sanitised; it is plain text now. Changelog entries rewritten for users. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- @file text no longer counts as the request: chat() and run_task() take attachments separately, so a question about an attached file is not re-prompted for a tool call, and the session title, episode task and reviewer task hold only what the user typed (goal mode too). - [f] at a prompt shows only this file's diff; the stored preview is forgotten before every tool prompt. - "a" is offered only where it is honoured: on tool prompts, including a child agent's prompt routed to the parent terminal (which now also keeps its rejection reason); not on "Keep going?", save or export prompts. - URL tools are allowed per host; allows end on /cd and /clear. - The GUI rejection event keeps its exact "rejected by user" summary. - No spinner over shell, git or test runs (a subprocess may prompt on the terminal), nor while a background child compacts its history; an ordinary JSON code block is no longer reported as a tool call in progress. - The end-of-task footer and sensitive-file warning cover this task's files only; a tool call that could not be read is now reported to the user. - POSIX paste coalescing reads the terminal file descriptor directly, so a single read holding several pasted lines loses none of them. - basedpyright baseline entries refreshed for the touched coder files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A paste that starts with "/export notes.md" used to append the pasted lines to the command's argument. The reader now returns the typed text and the pasted lines separately: a /command gets only what was typed (and says the pasted lines were not used), a chat message gets all of it, and @file mentions are read from the typed text only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Matlan1
removed
the
mutation-test
Matlan1
added a commit
that referenced
this pull request
Oct 20, 2026
…user or a plan prompt waits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fat the prompt shows the full diff.aallows that tool for the rest of the session (for shell tools, that exact command only; never waives the shell guard, a loosely formatted call oralways_confirm),n: <reason>or any other text rejects and sends the text back to the agent.set_todosrenders as a checklist.@path/@path:10-40attach a file throughread_file(same confinement and truncation as the model's own read; outside/scopeis skipped). A multi-line paste arrives as one message.[bold]tags.Verification
tests/plugins/coder/test_coder_ui_ux.py: 21 tests; the session-allow, free-text and markup tests were fires-controlled (red on the injected defect, green on the fix).tests/plugins/coderplus the top-level coder and stream-scroll tests, 3068 passed, 2 skipped.astopped the second write prompting whilerun_shellstill prompted, the rejection reason and the@notes.pyattachment reached the model's request, a 3-line paste arrived as one message.🤖 Generated with Claude Code