Add harm bound to AHR designs#640
Conversation
This reverts commit 9b59c45.
The helper-support-as_rtf.R is auto-sourced by testit, so the explicit source() call failed during R CMD check. Also update as_gt and as_rtf snapshots to reflect the new bound ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Run roxygenize to sync Rd files with code (fixes WARNING) - Remove test-independent-as_rtf.R (the .md snapshot is sufficient) - Replace all() with bare logical vector in test assertions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…alone Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Note on snapshot test changesThe This means every analysis section in both The other visible change in |
|
Correction on the alignment change: the |
|
Thank you @yihui for helping with the |
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
I only looked at the test part as I don't have expertise on the design part.
|
|
||
| ```{r} | ||
| candidate_harm_bounds <- lapply(astar_candidates, function(astar_candidate) { | ||
| gs_harm <- gsDesign::gsSurv( |
There was a problem hiding this comment.
The pkgdown workflow failed with the error ! unused arguments (sfharm = gsDesign::sfHSD, sfharmparam = -2) because this new article requires the dev version of {gsDesign}
There was a problem hiding this comment.
What's the plan for this vignette? Are we going to wait for the next release of {gsDesign}, or should we extract this vignette and save it for a follow-up PR?
There was a problem hiding this comment.
Keaven will release a new version of gsDesign next week, and he agrees that we merge this PR after his release.
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
The tests of gs_{design/power}_{ahr/npe} look good now. I would still like to see some tests for the other functions updated by this PR (as_gt(), gs_bound_summary(), and summary.gs_design()).
Also, we need to decide on the plan for the vignette.
| Rcpp | ||
| Roxygen: list(markdown = TRUE) | ||
| RoxygenNote: 7.3.3 | ||
| Config/roxygen2/version: 8.0.0 |
There was a problem hiding this comment.
We could temporarily require the dev version of gsDesign:
| Config/roxygen2/version: 8.0.0 | |
| Config/roxygen2/version: 8.0.0 | |
| Remotes: keaven/gsDesign |
and remove this Remotes field after the new version of gsDesign is on CRAN.
4 participants
To solve issue #618.
@jdblischak: In addition to "Efficacy" and "Futility" bound, I added "Harm" bound, which sequentially leads to some changes in
gs_bound_summary(). The changes ings_bound_summary()is suggested by GPT5.5. Could you please review if these AI-suggested changes looks good to you?