#198 - Enable SWC for Neurons Fixed - #171
Merged
Merged
Conversation
…vas.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes bug #198 by enabling SWC support for Neurons.
- Updated logic in the InstancesReducer to correctly locate and update a matching 3D object.
- Expanded and refined the SWC file fetching and error handling in the ThreeDCanvas component.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/virtual-fly-brain/client/src/reducers/InstancesReducer.js | Changed the iteration method from forEach to find to correctly update the matching object's visibility. |
| applications/virtual-fly-brain/client/src/components/ThreeDCanvas.js | Improved SWC file fetching logic including enhanced URL determination and error handling. |
…vas.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ddelpiano
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug #198, enables SWC for Neurons.