Caching mechanism - #187
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a disk-based caching mechanism for the Virtual Fly Brain backend to improve performance by reducing API calls to vfbquery. The caching system uses TTL (time-to-live) expiration and includes automated cleanup via cron jobs.
- Adds disk-based caching for term info and query results with 3-day TTL
- Implements cache management utilities with cleanup automation
- Includes various frontend code improvements and optimizations
- Reduces resource allocation for the deployment
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/virtual-fly-brain/backend/virtual_fly_brain/services/cache_utils.py | Core caching implementation with DiskCache class |
| applications/virtual-fly-brain/backend/virtual_fly_brain/services/term_info.py | Updated term info service with caching integration |
| applications/virtual-fly-brain/backend/virtual_fly_brain/services/queries.py | Updated queries service with caching integration |
| applications/virtual-fly-brain/backend/virtual_fly_brain/services/cache_manager.py | Command-line utility for cache management and statistics |
| applications/virtual-fly-brain/Dockerfile | Adds cron service and cache cleanup automation |
| applications/virtual-fly-brain/backend/docker-entrypoint.sh | Entrypoint script for Docker container setup |
| applications/virtual-fly-brain/backend/vfb_cache_cleanup.sh | Shell script for automated cache cleanup |
| applications/virtual-fly-brain/deploy/values.yaml | Reduces resource allocation for deployment |
| applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx | Improves text handling and memory management |
| Multiple frontend files | Various code cleanup, unused import removal, and styling fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+150
to
+155
| // Merge with existing tags, preserving active state for existing ones | ||
| const prevTagsMap = new Map(prevTags.map(tag => [tag.label, tag.active])); | ||
| return calculatedChipTags.map(newTag => ({ | ||
| ...newTag, | ||
| active: prevTagsMap.has(newTag.label) ? prevTagsMap.get(newTag.label) : true | ||
| })); |
There was a problem hiding this comment.
The Map creation and mapping operations are performed inside useEffect on every calculatedChipTags change. Consider using useMemo for the prevTagsMap creation to optimize performance when calculatedChipTags changes frequently.
Robbie1977
pushed a commit
to VirtualFlyBrain/virtual-fly-brain
that referenced
this pull request
Jan 26, 2026
Robbie1977
pushed a commit
to VirtualFlyBrain/virtual-fly-brain
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.