Repository navigation
Conversation
jonasbhend
reviewed
Oct 7, 2026
jonasbhend
left a comment
Contributor
There was a problem hiding this comment.
Hi @lclanzi. I see where you are coming from, but I wonder if we should think a bit harder about how to tackle this. My concerns are the following:
- The PR only implements it for regions (not init_hours or seasons). While I get that the situation is slightly different for these (as the default is
allfor init_hours and seasons, and we don't want to have anallregion to avoid ambiguity), one could argue that making all 'default' stratification explicit would be useful. - I quite like the current solution for its simplicity, but agree that it is not well documented. Could we just improve the documentation to clarify (which would be a much smaller change)?
Maybe we need other opinions on this...
Contributor
Author
|
I agree that this methodology introduces some inconsistencies with how season and init_hour are handled. I think the simplest solution is indeed to add a comment in the config clarifying that the first region in the list is used. Feel free to close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When region stratification is not active, the dashboard, metric plots and scorecards silently used the first region listed under experiment.stratification.regions. There was no way to choose a different one without reordering the list.
This PR adds an optional
experiment.stratification.default_regionsetting so the region can be chosen explicitly: