Skip to content

Add optional default region for non-stratified results - #268

Closed
lclanzi wants to merge 1 commit into
mainfrom
feat/default-region
Closed

lclanzi wants to merge 1 commit into
mainfrom
feat/default-region

Conversation

@lclanzi

@lclanzi lclanzi commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

When region stratification is not active, the dashboard, metric plots and scorecards silently used the first region listed under experiment.stratification.regions. There was no way to choose a different one without reordering the list.

This PR adds an optional experiment.stratification.default_region setting so the region can be chosen explicitly:

experiment:
  stratification:
    regions: [icon, mittelland, berge, alpennordseite, alpensuedseite, jura]
    default_region: icon

@lclanzi
lclanzi requested review from dnerini and jonasbhend October 6, 2026 17:06

@jonasbhend jonasbhend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lclanzi. I see where you are coming from, but I wonder if we should think a bit harder about how to tackle this. My concerns are the following:

  • The PR only implements it for regions (not init_hours or seasons). While I get that the situation is slightly different for these (as the default is all for init_hours and seasons, and we don't want to have an all region to avoid ambiguity), one could argue that making all 'default' stratification explicit would be useful.
  • I quite like the current solution for its simplicity, but agree that it is not well documented. Could we just improve the documentation to clarify (which would be a much smaller change)?

Maybe we need other opinions on this...

@lclanzi

lclanzi commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

I agree that this methodology introduces some inconsistencies with how season and init_hour are handled. I think the simplest solution is indeed to add a comment in the config clarifying that the first region in the list is used. Feel free to close the PR.

@lclanzi lclanzi closed this Oct 12, 2026
@lclanzi lclanzi reopened this Oct 12, 2026
@lclanzi lclanzi closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants