Skip to content

feat(i18n): localize session settings and track page coverage - #311

Closed
oscarlius wants to merge 1 commit into
MiaAI-Lab:mainfrom
oscarlius:codex/i18n-settings-sessions-20261031
Closed

oscarlius wants to merge 1 commit into
MiaAI-Lab:mainfrom
oscarlius:codex/i18n-settings-sessions-20261031

Conversation

@oscarlius

@oscarlius oscarlius commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Consolidated into #310. The session-settings translations and page coverage checklist are now included in #310 at commit 6b9b5b3, together with MQTT/GPU Settings work. The combined branch passed all tests, typecheck and build; closing this duplicate PR to keep one Settings review.


Settings' Session age and Harness sessions entry still displayed English after the language foundation. This adds their labels, help, accessible group name, seven hour/day choices and setup button to the existing English and Simplified Chinese catalogs. The selected duration, default 12-hour fallback, millisecond payload and setup callback stay unchanged across locale switches. The age row reuses the existing stacked layout so Chinese options wrap without clipping on a narrow screen.

Adds docs/I18N-COVERAGE.md, linked from README: a source-linked inventory of navigable pages and independent dialogs that distinguishes the merged #226 foundation, pending #310 MQTT/GPU work, this session-settings slice, and screens not yet wired. It includes per-page acceptance and merge-update steps, and explicitly separates translated controls from raw diagnostics and terminal output. The separate Harness setup wizard remains a future slice.

This is an independent PR from current main (b96244a), without the commits from #310. It addresses the session rows listed as remaining work there. #194 remains an integration/translation reference. No dependency, server or deployment changes.

Validation (Linux, Node 24.19.0):

  • npm test: catalog validation passed; checker 11/11, server 1428/1428, frontend 787/787; no skips.
  • npm run typecheck and npm run build: passed (build reports a chunk-size warning).
  • Regression tests cover locale round-trips, all seven labels, the default/pending selection, one unchanged millisecond save payload, and the existing setup callback without incidental reads/writes.
  • Mocked browser fixture: desktop and 390px layouts in English/Chinese, retained pending selection, and no horizontal overflow or writes during switching.
  • 45 coverage-document source links checked; review's missing terminal-output entry added.

Translate session age controls and the Harness setup entry while preserving stored millisecond values and callbacks. Reuse the stacked row layout so translated presets wrap on narrow screens. Track merged, pending and unlocalized surfaces in a source-linked inventory.

Constraint: Independent Settings follow-up on main; MiaAI-Lab#310 stays separate and MiaAI-Lab#194 remains a reference.

Confidence: high

Scope-risk: narrow
@oscarlius oscarlius closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant