Repository navigation
Conversation
|
First review, at |
|
Showcase controls/session feedback; small and late in the chain. Same rebase/key-check bar; nothing further from my pass. (Review notes prepared with Claude Code on behalf of the maintainer.) |
Embedded and full-screen Showcase views now localize controls, session feedback and terminal chrome. Prompts, streamed model output, model names and session data remain unchanged. Constraint: Separate review against current main; no merge or production deployment. Not-tested: Fresh full Linux server suite (local WSL E_UNEXPECTED) and exhaustive desktop/narrow visual acceptance. Confidence: medium Scope-risk: moderate
Constraint: Documentation-only follow-up; retain pending review and validation gaps. Confidence: high Scope-risk: narrow
Constraint: Documentation link only. Confidence: high Scope-risk: narrow
Constraint: Preserve pending-review status; no merge, production traffic or deployment. Not-tested: Exhaustive layouts, themes, error states and real-device workflows. Confidence: high Scope-risk: narrow
Constraint: Preserve raw Showcase export text and pending-review boundaries; no merge, deployment, or production traffic. Not-tested: Full npm test and real-browser/device acceptance. Confidence: high Scope-risk: narrow
Restore the MiaAI-Lab#324 changelog entry after resolving the shared changelog conflict in favor of current main content. Constraint: Preserve origin/main changelog entries and Showcase behavior; no deployment or push Confidence: high Scope-risk: narrow
68f0b18 to
5f32662
Compare
The Overview energy card, the Energy page and the monthly view were localized by #316/#320 and extended by #312 in the same lines; the merge keeps the wall-power logic and routes its new strings through the overview and statistics catalogs (English and 简体中文 added for the wall labels, notes and monthly footer). The coverage inventory marks the landed slices as merged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Embedded and full-screen Showcase views now localize controls, session feedback and terminal chrome. Prompts, streamed model output, model names and session data remain unchanged.
Scope:
showcasenamespaces. This is one of six complete-feature migrations reusing the reviewed wording/design from #194, implemented on currentmain(b96244a). #194 remains unchanged as the historical reference. Settings #310 is now on main via the maintainer's author-preserving port; #315–#319 remain separate reviews.Validation:
2a16e5a: 800/800 frontend tests, typecheck, catalog checks and production build passed. Follow-up48dbf89passed the affected static-key/raw-response regressions and type/catalog/build checks.c2b5538: 1 targeted frontend regressions plus typecheck/catalog validation passed.npm run test:serverpassed 1,433/1,433, 0 failures, 0 skips, on the combined48dbf89source in an isolated Debian Bookworm / Node 24.19.0 container. Its server tree is identical to feat(i18n): add bounded server message metadata and rendering #325; the other five feature reviews do not modify the server. The earlier Windowsnpm testattempt remains incomplete.Integration: merge the loader resources/catalogs and documentation additively, retaining every already-merged namespace and older pending review. The server-message group should be integrated after fleet reports and Spark details because it adds metadata rendering to the same EventRow/SparkActions surfaces; its HealthFindings integration also overlaps #316. PR creation does not authorize merging.
Progress: Unified localization index. Settings #310 (completed on main); Shell #315; Overview #316; resource panels #317; LLM live/sessions #318; LLM history/totals #319; fleet reports/activity/kiosk #320; device setup #321; remaining Spark panels/model operations #322; benchmarks/share cards #323; Showcase #324; server messages #325. All remain separate reviews. #194 stays open as the historical reference. Source is included in the private local showcase; no upstream PR was merged.
Maintainer feedback follow-up (2026-11-01): author review.
68f0b18localizes clear-history confirmation and refreshes its callback on locale change. Two focused Showcase locale/terminal tests, typecheck, catalog validation and production build passed. Six unused catalog leaves belong to the unchanged plain-text copy format (answer/status/port/title/average/server labels); those exported bytes and raw model output remain unchanged.Current PR head:
68f0b18. Unified progress and feedback record. Previous no-feedback/CI snapshot is superseded for review status; local test evidence is separate from GitHub CI. No PR merge, rebase or.9deployment was performed by this follow-up.Current-main maintainer follow-up (2026-11-03)
Addressed latest maintainer feedback at
5f32662, rebased onto main7c2b963. Keep landing order #315, then #316–#325 in numeric order; separate PRs still target main and shared catalogs/loaders must be combined additively.Rebased Showcase while retaining clear-history locale switching and untouched raw prompts/output.
Local validation completed before this push/PR update: per-PR catalog/type checks and affected regressions; final integrated source
cf08c32passed 888 frontend tests (136 files), typecheck, catalog/checker tests and production build. Linux server validation passed 1,463 tests, 0 failures/skips on3f61343, whose server tree is identical tocf08c32. Fresh Overview/Kiosk acceptance at 1440×1000 and 390×1000 in English/zh-CN found no page overflow or browser errors. Actual Canvas exports were checked at both viewport widths (2400×1350 backing image), with markup-like raw user strings remaining literal text. These are local checks, not GitHub CI: audited heads had no check runs/statuses or PR Actions runs.The local showcase includes this submitted source and retains native Maya monitoring. Unified current progress and evidence. No upstream PR merge was performed; #194 remains untouched as the maintainer-requested reference.