Repository navigation
feat(overview): dismissible fleet alert rows with a small x - #374
Open
yr75myjnqx-tech wants to merge 1 commit into
Open
yr75myjnqx-tech wants to merge 1 commit into
yr75myjnqx-tech wants to merge 1 commit into
Conversation
Adds a compact dismiss (x) button to each FleetAlertStrip row so a noisy but known alert (e.g. 'Unified memory is running low' on a box that is expected to run its unified memory tight) can be cleared without losing the strip for everyone. - Dismissal is session-only component state: a page refresh restores the warning, so nothing is ever permanently silenced. - If the underlying condition clears and later fires again, the row reappears without a refresh (dismissed keys are pruned when inactive). - Throttle alerts are safety-relevant and get no dismiss button. - New overview:alerts.dismiss i18n key (en + zh-CN) and .ov-alert__dismiss styles; the existing Open button stays first so keyboard/automation flows that target the row's primary action are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On boxes that are expected to run their unified memory tight (e.g. a GB10 serving an FP4 model that intentionally holds ~93 of 121 GB), the Overview page shows a persistent "Unified memory is running low — 2.7 GB available" strip row. The condition is by-design, so the alert is noise — but the row can't be cleared, and it sits at the top of the Overview indefinitely.
Change
Adds a small x dismiss button to each
FleetAlertStriprow:showExceptionsfiltering), so the x is omitted for them.overview:alerts.dismissi18n key (en + zh-CN) and.ov-alert__dismissstyles (24px hit target, muted color, hover state).Tests
FleetAlertStrip.test.tsx: dismiss hides the row; remount (refresh) restores it; clear-then-refire restores it without a refresh; throttle rows render no dismiss button.FleetAlertStrip.test.tsx: 11/11 passing. Full suite: 900/900 tests passing.upstream/maincheckout (missingsrc/shared/mainFilesystemimported bySparkCard.tsx) — pre-existing on main, unrelated to this PR; the same files fail identically with and without this change.