Repository navigation
fix(health): distinguish low-power inference progress from possible stalls - #377
Open
danieljohnmorris wants to merge 1 commit into
Open
danieljohnmorris wants to merge 1 commit into
danieljohnmorris wants to merge 1 commit into
Conversation
Contributor
Author
|
Follow-up verification: built a separate test copy of this PR with only the existing main-filesystem build repair from #372 (81360aa) applied locally. That repair remains outside this PR.
The live readings in this browser check were above the preserved 11 W threshold, so the progressing-versus-stalled distinction remains separately verified by the earlier real-probe replay with a simulated 9 W condition and the head/worker regression tests—not inferred solely from the absence of a warning in the browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Low GPU power plus high utilisation does not establish a stall. During a read-only observation of a three-Spark TensorFold workload, requests continued completing while the dashboard showed low-power warnings. Long prefills also advanced while decode counters temporarily stayed flat.
This branch starts from freshly pulled upstream
main(e89f8d1). It preserves the recently tightened 11 W / 30 consecutive GPU samples rule rather than replacing that fix.Change
Unknown progress still permits the existing observational warning; this does not claim to diagnose a GPU fault or prove that every request is healthy.
Verification
Existing main-branch validation blocker
npm run typecheck,npm run build, and 10 frontend test suites cannot resolve../../shared/mainFilesystemimported bysrc/components/OverviewPage/SparkCard.tsx. The import and missing module are present in baselinee89f8d1, not introduced here; #372 already includes a separate repair. The remaining 131 frontend suites / 897 tests passed. That unrelated repair is intentionally not bundled into this PR. Browser verification of the rebuilt frontend is blocked by the same missing module.No production deployment is included.