Repository navigation
Update DesktopWindowXamlSource to describe how to avoid leaks - #2054
Chris Guzak (ChrisGuzak) wants to merge 7 commits into
Conversation
PRMerger7
added
the
do-not-merge
|
Chris Guzak (@ChrisGuzak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
PRMerger10
added
uwp/prod
|
thanks Chris Guzak (@ChrisGuzak)! For future reference could you instead post draft PRs to https://github.com/microsoftdocs/windows-uwp-pr ? Tagging Oscar Calvo (@ocalvo) and Austin Lamb (@Austin-Lamb) for comments on the content as well. |
Kristine Toliver (ktoliver)
added
the
aq-pr-triaged
…tthread_14911797.md Co-authored-by: Alexander Sklar <asklar@microsoft.com>
|
Chris Guzak (@ChrisGuzak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
…tthread_14911797.md Co-authored-by: Alexander Sklar <asklar@microsoft.com>
|
Chris Guzak (@ChrisGuzak) : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
| m_xamlManager = nullptr; | ||
|
|
||
| // Drain the message queue after releasing WindowsXamlManager since rundown is async | ||
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) |
There was a problem hiding this comment.
while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE))
| // Drain the message queue after releasing WindowsXamlManager since rundown is async | ||
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) | ||
| { | ||
| ::DispatchMessageW(&msg); |
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) | ||
| { | ||
| ::DispatchMessageW(&msg); | ||
| } |
|
Closing this pull request because it has been open for more than three years. If the change is still relevant, please open a new pull request against the current branch. |
still need to check the details on this given the fixes that went into SV, but creating this to get early feedback.