Extend the scope of the project#4
Closed
xaviergmail wants to merge 9 commits into
Closed
Conversation
Owner
|
Hey, I'm just following up to say I'm not ignoring this PR, I'm just incredibly busy outside of GMod anymore and haven't had a chance to check this out. I think it's awesome how much you've expanded the project. |
|
Any news on this PR @Mista-Tea ? |
Author
|
Just going through and cleaning my open PRs! In case anyone finds this in the future, I've essentially moved on away from Garry's Mod development, but the changes outlined in this PR along with more utilities can be found in xlib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fork I've been using personally for a while and I decided I might as well give back to the community so here it is. I'm making this PR to hopefully get it some extra publicity from the existing thread on the facepunch forum than trying to market my own fork.
These additions are what I feel make this library complete. I can't really think of anything else I'd like to add other than GM:NetRequest/Net/Client/GlobalVarChanged hook to capture every change regardless or entity or key but I can't think of a good use case for that, so I decided against it. I also think adding hooks to NetRequests should be relatively easy so that might be my next move.
This PR adds the following:
I suggest you view the README as well as the examples