Repository navigation
Conversation
pffexport rejected and truncated numbered item paths at five digits, so a folder with more than 100000 items could not be exported. Keep five-digit zero padding for smaller indexes and let sprintf grow the name for larger ones. Add an export_handle test that requires Message100001 for item index 100000. Co-authored-by: Gilad Leifman <Mizaro@users.noreply.github.com>
Co-authored-by: Gilad Leifman <Mizaro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pffexport 5-digit item directory cap tracked upstream as libyal/libpff#71.
export_handle_create_default_item_directoryused%05dand then treated any extra digit as an error, so item 100000 failed instead of becomingMessage100001. Five-digit zero padding is unchanged for indexes 1–99999.Tests follow the existing libyal layout:
export_handle_initialize/export_handle_free(regular and error cases)export_handle_create_default_item_directoryforitem_index == 100000, plus NULL/negative-index errorspfftools_output_copyright_fprint,pfftools_output_version_fprint, andpfftools_output_version_detailed_fprint(invocation plus NULL stream)The earlier Cygwin coverage failure was
#include <direct.h>when--enable-winapiis set. Cleanup now usesRemoveDirectoryon WINAPI andrmdirotherwise.How to verify