Fix racy shared RX test input buffers in set_job#1
Merged
MoneroOcean merged 1 commit intoMay 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
staticcontainer was used for parsed RX inputs, allowing concurrent RX worker threads to read job-specific data after a laterset_jobreassigns it, causing racy out-of-bounds accesses and undefined behavior.Description
static std::vector<std::string> new_input_hexeswith a per-jobstd::shared_ptr<std::vector<std::string>>created fromsplit_input(new_input_hex)and updated size checks to use the shared pointer.static std::vector<std::vector<uint8_t>> new_inputswith a per-jobstd::shared_ptr<std::vector<std::vector<uint8_t>>>and populate it from the dereferencednew_input_hexes.new_inputsandnew_input_hexesby value in the RX worker lambda and updated all worker accesses to dereference those shared pointers (for example(*new_inputs)[thread_id]and(*new_input_hexes)[thread_id]).m_input_cn_len,memcpy, nonce initialization) to reference the dereferencednew_inputsso behavior is preserved while fixing lifetime/synchronization issues.Testing
Codex Task