Fix stale CN input length causing OOB reads#3
Merged
MoneroOcean merged 1 commit intoMay 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
m_input_cn_lencould remain stale when consecutive jobs reuse the same algo/seed/mem configuration, leading tomemcpy()reading past the decoded blob.Description
m_input_cn_lenimmediately after decoding and validating inputs for every non-RX job and remove the redundant assignment from the reconfiguration-only branch so CN copying and hashing always use the current blob length (moner-job.cpp).Testing
npm test, but the native addon build could not complete because fetching thenandependency from npm was blocked with HTTP 403, so the test suite could not execute (no automated tests passed in this environment).Codex Task