Skip to content

Fix record_thread overwriting active worker IDs#5

Merged
MoneroOcean merged 1 commit into
mainfrom
codex/fix-record_thread-to-preserve-all-cluster-workers
May 27, 2026
Merged

Fix record_thread overwriting active worker IDs#5
MoneroOcean merged 1 commit into
mainfrom
codex/fix-record_thread-to-preserve-all-cluster-workers

Conversation

@MoneroOcean

Copy link
Copy Markdown
Owner

Motivation

  • The record_thread helper reset worker_ids before adding a single thread_id, which caused previously created workers to be dropped from messageWorkers broadcasts and lose future control messages.

Description

  • Change record_thread in index.js to append the thread_id only if not already present (i.e. if (!worker_ids.includes(thread_id)) worker_ids.push(thread_id);), preserving existing tracked worker IDs and avoiding duplicates while keeping create_thread behavior unchanged.

Testing

  • Ran npm test; the automated test run could not complete because npm failed to fetch the nan dependency (403 Forbidden), so the native addon build and test suite did not run successfully.

Codex Task

@MoneroOcean MoneroOcean merged commit 6b024a1 into main May 27, 2026
1 check passed
@MoneroOcean MoneroOcean deleted the codex/fix-record_thread-to-preserve-all-cluster-workers branch May 27, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant