Skip to content

json encoder#523

Closed
idoshr wants to merge 14 commits into
MongoEngine:masterfrom
idoshr:master
Closed

json encoder#523
idoshr wants to merge 14 commits into
MongoEngine:masterfrom
idoshr:master

Conversation

@idoshr

@idoshr idoshr commented May 13, 2023

Copy link
Copy Markdown
Contributor

Fix issue while try to inherit from MongoEngineJSONEncoder
and for bonus add doc of how add encoder hope it will be helpful

@insspb insspb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idoshr thank you for interest to this project.

I reviewed changes, being out of mongo right now. Please fix mentioned errors and I will recheck again.

Comment thread flask_mongoengine/json.py
):
return _convert_mongo_objects(obj)
return super().default(obj)
return superclass.default(obj)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Where it from?

Comment thread flask_mongoengine/exceptions.py Outdated
Comment thread docs/custom_json_encoder.md Outdated
Comment thread flask_mongoengine/pagination.py Outdated
@idoshr

idoshr commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

@insspb
What is your opinion on adding this default encoder
image

@EvanBldy

Copy link
Copy Markdown

Hi that's cool ! Thanks
Will you do a new release on pypi after that ?

@idoshr

idoshr commented Jun 16, 2023

Copy link
Copy Markdown
Contributor Author

This pull request spliced to 3 separated PRs
#526
#527
#528

@idoshr idoshr closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants