FA Road X Rail LHD Path Re-mapping - #497
Merged
Merged
Conversation
jflann
reviewed
Feb 16, 2025
jflann
left a comment
jflann
left a comment
Member
There was a problem hiding this comment.
Looks good. Please rename the pull request to something more descriptive of the changes it contains. Likewise, in the future try to write descriptive commit messages rather than accept the default (e.g., "Add FA Road x Rail LHD path remapping" vs "Update NetworkINI.ini")
| ;subsection covers normal networking & non-interchange base related items | ||
| ;road | ||
| 1 = 0x5F010400,0xFFFFFF00,0x7F010400,0x000000FF ;roadxrail | ||
| 2 = 0x5F092A00,0XFFFFFF00,0x7F092A00,0x000000FF ;FA3RoadxRail |
Member
There was a problem hiding this comment.
It would be better to follow the convention of the file and use tabs to indent these lines.
Fixed writing by replacing spaces with TAB, corrected numbering sequence
LucarioBoricua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added LHD / UK Path Re-mapping to support the FA-2 and FA-3 Road X Rail grade crossing paths