Repository navigation
Conversation
…nteractiveBundleShell>`
…gementConsolePage>`
There was a problem hiding this comment.
🤖 NCode Review at 851b273: 9 new findings on the changed lines.
Not on a changed line:
- 🟡 F4 Nit: ADR-1254's body still names the deleted
InteractiveBundleReaderdocs/decisions/1254-the-interactive-bundles-hashed-files-are-served-immutable-without-resolving-the-tenant.md:38. Decision 2 (lines 38-39) and the References list (line 87) still nameInteractiveBundleReader, itsAssetsDirectoryandInteractiveBundleReader.cs, all of which this PR deletes. Only the status line gained a note about the ADR-1457 amendment. Fix: Point the reference and decision 2's wording atsrc/NCode.AspNetCore/SinglePageBundle.csandSinglePageBundleDefaults.AssetsDirectory. Or, if the maintainers accept the status-line note in place of editing the body, confirm that is enough. - 🟡 F5 Nit: Catalog entry still uses the front-channel marker's old names
CHANGELOG.md:4371. The 'No CORS on the front-channel endpoints' entry namesIOpenIdEndpointFrontChannelMetadataandWithOpenIdFrontChannel(), which ADR-1388 renamed toIFrontChannelEndpointMetadataandWithFrontChannel(). Fix: Rename both identifiers in that entry.
|
Superseded by the review at 9ec8e47. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 94.47% 94.21% -0.26%
==========================================
Files 1873 1872 -1
Lines 81967 81916 -51
Branches 268 308 +40
==========================================
- Hits 77440 77180 -260
- Misses 4527 4736 +209
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
…st-modified time and give the test index its own file
…ost chart workflow
|
Autopilot: #618 (review)
|
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 851b273: 12 hunks in 10 files and changes taken back in 6 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed, F6 fixed, F7 fixed, F8 fixed, F9 fixed, F10 fixed, F11 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.09 on Amazon Bedrock, 15s, at 9ec8e47. (how to interact) 📋 OutcomesMerged at b583b7a: 9 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
|
Autopilot: this pull request is ready to merge as far as this run can tell. One round of review feedback was fixed (the console Deployment's strategy check, strict UTF-8 on the console page, the narrowed test delegate, the last-modified assertion, the test index's own file, ADR-1458's wording, the wraps and the front-channel catalog entry), ADR-1254's body was answered with the Status-line amendment, and NCode Review's re-review at 9ec8e47 approves with no further findings. The threads are answered and wait for you to resolve them. Once it merges, this run makes the |
The management console host ships as its own image and an opt-in component of the host chart, and both hosts share their health-probe mapping and their single-page bundle serving.
MapHealthProbes()inNCode.AspNetCoremaps/health/liveand/health/readyfor both hosts, andHealthCheckTagslives inNCode.Registration(ADR-1456).SinglePageBundle<TIndex>inNCode.AspNetCorereads the index once per file version and serves only hashed files underassetswith immutable caching; the login pages useSinglePageBundle<InteractiveBundleShell>and the consoleSinglePageBundle<ManagementConsolePage>(ADR-1457).@ncode/app-mgmton the OP image's pinned, chiseled non-root bases; aConsole imageworkflow builds it with its own cache scope; Dependabot moves both images together; the host chart's opt-inmanagementConsolecomponent runs it under restricted pod security with its keys from Secrets and one Ingress on its host that sends/apito the OP (ADR-1458).Closes #609
Closes #610
Closes #612