Repository navigation
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Background. Each repository needs a place for its own review settings that the template never renders (so Copier never deletes it) and that is always read from the default branch, so a PR can't soften its own review:
.github/code-review/config.yml:sensitive:path globs (Deep reviews for sensitive paths, and a light path for documentation-only pull requests #42)skip:path globs never reviewed (e.g. vendored code)policies:documents every reviewer gets as conventions (e.g. Identity'sdocs/api-compatibility.md, 5.6 KB, read by no reviewer today)- optional
tiers:overrides
.github/code-review/guidance.md: project rules, written by hand or by/review teach(/review teach: turn a correction into lasting guidance #45). They join the context stage's catalog like.github/instructionsrules..github/code-review/reviewers/*.md: project-only charters, same format asreviewers/*.mdin the engine. For example, an OAuth/OIDC/JOSE conformance reviewer for Identity. The selection model may add them; apaths:frontmatter adds one to the floor.
Current state. src/gather.ts reads only AGENTS.md sections and .github/instructions/*.instructions.md from base. No repository has .github/code-review/ (Identity returns 404).
What to do.
- In
gather(), read the three sources frombasePathonly, neverprPath. Validateconfig.ymlwith a small schema. An invalid file gives a warning in the check run and defaults, not a failed run. policies:files are appended toconventionswith their path, withinmaxConventionChars(raise it, or give policies their own budget).skip:files are listed as "skipped by config" in the check run, never silently dropped.- Project charters are loaded alongside
loadCharters(root), prefixedproject:; an engine charter of the same name is not overridden. - Document the folder in the README, with an Identity example.
Acceptance.
- A unit test with a fixture
baseshowing that each setting takes effect. - A PR that edits
.github/code-review/config.ymlis reviewed with the default branch's copy (test with differing base and head copies). - Identity can add
policies: [docs/api-compatibility.md], and theapi-compatreviewer's prompt contains it (visible in the trace).
Filed from the 2026-10-31 audit of the NCodeGroup review-bot and project-template design against what was built. This issue stands alone: everything needed to do it is above.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Activity