Repository navigation
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 8d09af6: 4 new findings on the changed lines.
|
Superseded by the review at 63b1f8e. |
This was referenced Oct 31, 2026
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 8d09af6: 4 hunks in 3 files and changes taken back in 1 file, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed, F4 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 10s, at 63b1f8e. (how to interact) 📋 OutcomesMerged at 63b1f8e: 2 fixed, 2 dismissed, 0 acknowledged, 0 ignored.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification counts a refuted finding it kept as a question (a blocker, a
securityfinding, or one whose refutation cites only added lines) apart from one it couldn't settle, so first-review and re-review summaries say "refuted but kept" instead of "couldn't settle"; a re-review that kept a refuted should-fix as an unposted nit never approves (#114).A re-review merges a problem
correctnessandsecurityboth report (same file, within three lines, same title words) into one finding at the higher severity naming both reviewers, and logsmergedandnearcounts for the evals (#116).An eval case can set
sensitivepaths; two new re-review cases cover the security floor (src/claims.ts) and a deepsensitive:re-review (src/fetch-head.ts), and--subset re-reviewruns the four re-review cases with each one's cost (#117).The branch merges
mainin to resolve aCHANGELOG.mdconflict, so merge this with a merge commit, not by rebasing.Closes #114
Closes #116
Closes #117
A first review round clarified the README's verification sentence, tested the plural wording, shared the distance check and linked the eval references; main is merged in.