Repository navigation
Conversation
There was a problem hiding this comment.
🤖 NCode Review at d88b4de: 2 new findings on the changed lines.
Not on a changed line:
- 🟡 F2 Nit: No test covers when main() reads the git history
evals/smoke.ts:165.main()looks updeletedInonly when the baseline path is the committed default and the file is missing, and no test covers that condition. Its parts (smokeCheck,checkFileswithdeletedIn,lastBaselineCommit) are each tested. Fix: Optional: move the condition into a small exported function and test it with the default path, a--baselinepath and a file that exists.
|
Superseded by the review at fd9d544. |
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at d88b4de: 6 hunks in 4 files and changes taken back in 3 files, by correctness only. Earlier findings: F1 still open, F3 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 9s, at fd9d544. (how to interact) 📋 OutcomesMerged at fd9d544: 1 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
polewskm
marked this pull request as ready for review
October 31, 2026 23:20
This was referenced Oct 31, 2026
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke eval now fails when
evals/baseline-smoke.jsonis missing after it was committed, naming the deleting commit (it still passes with a notice before the first baseline; a shallow checkout fails closed, so the workflow fetches full history). New tests pin the smoke eval workflow's order and thatevals/run.tswrites its output before failing a run over--max-cost, via an exportedwriteRunOutput.The loop limit, open-issue synthesis and
Autopilot:replies now use the engine'swriterCheck(association, then a cached permission lookup that fails closed), so a private organization member counts; open-issue author lookups are capped at 20. The/reviewgate stays association-only, and the README tells private members how to use it.Two merge steps bring in
origin/main, so this pull request must merge with a merge commit, not by rebasing.Closes #93
Closes #89
A first review round moved the shared writer-check test stub into one module.