Repository navigation
Refactor slice B: module moves and shared helpers - #127
Merged
Merged
Conversation
…d review-prompts tests
There was a problem hiding this comment.
🤖 NCode Review at 6784e11: 1 new finding on the changed lines.
|
Superseded by the review at 3a08a59. |
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 6784e11: 2 hunks in 1 file and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 9s, at 3a08a59. (how to interact) 📋 OutcomesMerged at 3a08a59: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice B of the #95 refactor: module moves and shared helpers, with no change in behavior.
gather.tstocontracts.ts,stoppedBytochecks.ts(withNoProviderErrorin its ownno-provider.ts, so the acknowledgement still loads no provider code), and reading a finding comment's title and text tothreads.ts.review()takes an options object, runs its reviewer calls inrunReviewers(), finishes infinishReview(), and runs a light review in its ownreviewLight(); every caller and test passes the same arguments as before.EvalOutputtype its writer and readers share, one helper counts the findings that belong upstream, and the workflows read the Node version from.node-version.mainin (merge commit, so this must merge with a merge commit, not by rebasing) to resolve the changelog andtest/acknowledge.test.ts.Refs #95
A first review round dropped the leftover NoProviderError re-export.