Skip to content

Refactor slice B: module moves and shared helpers - #127

Merged
polewskm merged 21 commits into
mainfrom
refactor-95b
Nov 1, 2026
Merged

polewskm merged 21 commits into
mainfrom
refactor-95b

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Slice B of the #95 refactor: module moves and shared helpers, with no change in behavior.

  • The C# contract checks move from gather.ts to contracts.ts, stoppedBy to checks.ts (with NoProviderError in its own no-provider.ts, so the acknowledgement still loads no provider code), and reading a finding comment's title and text to threads.ts.
  • review() takes an options object, runs its reviewer calls in runReviewers(), finishes in finishReview(), and runs a light review in its own reviewLight(); every caller and test passes the same arguments as before.
  • The eval output file has one EvalOutput type its writer and readers share, one helper counts the findings that belong upstream, and the workflows read the Node version from .node-version.
  • Merges main in (merge commit, so this must merge with a merge commit, not by rebasing) to resolve the changelog and test/acknowledge.test.ts.

Refs #95

A first review round dropped the leftover NoProviderError re-export.

@polewskm
polewskm deployed to code-review November 1, 2026 00:43 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 6784e11: 1 new finding on the changed lines.

Comment thread src/provider.ts Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at 3a08a59.

@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 6784e11: 2 hunks in 1 file and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 9s, at 3a08a59. (how to interact)

📋 Outcomes

Merged at 3a08a59: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene 🟡 Nit ✅ fixed

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 00:53
@polewskm
polewskm deployed to code-review November 1, 2026 00:53 — with GitHub Actions Active
@polewskm
polewskm merged commit f4a51bc into main Nov 1, 2026
7 checks passed
@polewskm
polewskm deleted the refactor-95b branch November 1, 2026 00:53

This branch was successfully deployed

1 active deployment
code-review — 3a08a598 Deployed Nov 1, 2026 by polewskm via review #399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant