Repository navigation
Finish the engine refactor of #95 - #129
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 8354232: 1 new finding on the changed lines.
Not on a changed line:
- 🟡 F2 Nit: Taught-rule text still gets mention-only escaping
src/teach.ts:56.src/teach.tsstill usesneutralizeMentionsat lines 47 and 56, so a link in a taught rule or in the 'Review guidance:' line stays live. Is that intended, given the rule is maintainer text and not model text? Fix: Switchsrc/teach.tslines 47 and 56 toneutralizeProse. Or, if taught rules are meant to keep links, say in the changelog that they are maintainer text and only mentions are escaped.
|
Superseded by the review at 8354232. |
|
Autopilot: ready to merge as far as this run can tell. The plan's review caught and fixed two should-fix problems before the push: a lone carriage return reopening a ping, and a flow-mapping root parsing. The bot's review raised one question, which doesn't hold (file paths in code spans never pass through |
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 8354232: 2 new findings on the changed lines.
🤖 Review completeVerdict: 💬 Comment — This finishes the #95 refactor. The remaining GitHub reads move onto the shared client in 8 reviewers run — 2 findings (run details)
Skipped: api-compat, data-model, infrastructure, performance, tests Findings
Trial: findings are posted as review threads and in the check run. $0.91 on Amazon Bedrock, 82s, at 8354232. (how to interact) 📋 OutcomesMerged at 8354232: 0 fixed, 3 dismissed, 0 acknowledged, 0 ignored.
|
|
On the
|
Finishes the engine refactor of #95. The remaining GitHub reads (open and closed issues, permission lookups, the training's guidance issues) move onto the shared client in
src/github.ts, and outcomes and the publish step's dismissals use the one writer check.The finding marker is read in one place (the last marker, which fixes outcomes recording the wrong finding when a suggestion holds a marker-like line), and gather and the template check share one git read.
Model-written text in every bot comment goes through
neutralizeProse, so it can no longer mention anyone or post links, while code spans and fences stay intact.config.ymlis parsed with theyamllibrary (failsafe schema, same error shape), and one check covers path items.Closes #95