Skip to content

Run a plain /review only on an open pull request - #144

Merged
polewskm merged 2 commits into
mainfrom
open-pr-review-guard
Nov 1, 2026
Merged

polewskm merged 2 commits into
mainfrom
open-pr-review-guard

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #143, from the bot's reviews of the consumer rollout PRs (for example NCodeGroup/Base64Url#21, NCodeGroup/Mediator#21 and NCodeGroup/NCode.Disposables#24):

  • A plain /review now runs only on an open pull request. A /review on a pull request that just closed could cancel the outcomes run, or displace it while it waited, because the two share a concurrency group. /review explain and /review teach still answer on a closed pull request, since each has a group of its own. A test asserts the guard in both the workflow and the README's caller.
  • The workflow's header no longer warns about pins up to v0.3.1. It now says why outcomes needs no environment: the app key is an organization secret, and the code-review environment only lets Anthropic's federation rule trust the review job.
  • The if comment no longer says the command must be exactly /review.

Refs #97

@polewskm
polewskm deployed to code-review November 1, 2026 07:45 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 927419c: 1 new finding on the changed lines.

Comment thread test/outcomes.test.ts Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at d946379.

…etup note, and test their closed-pull-request exemption
@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 927419c: 5 hunks in 3 files and changes taken back in 2 files, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 7s, at d946379. (how to interact)

📋 Outcomes

Merged at d946379: 1 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check 🟡 Nit ✅ fixed

This branch was successfully deployed

1 active deployment
code-review — d9463790 Deployed Nov 1, 2026 by polewskm via review #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant