Follow up the engine fetch's review: a fetch time limit, a testable skip decision, sturdier tests by polewskm · Pull Request #22 · NCodeGroup/code-review

Follow up the engine fetch's review: a fetch time limit, a testable skip decision, and sturdier tests

polewskm

committed

ab5859f

Make the fetch's time limit testable and required, and take the skip decision in one place

polewskm

and

claude

committed

271d154

Give git one options argument, and split the command and skip tests out

polewskm

and

claude

committed

c314012

Look the reviewed head up only when it can matter, and log a failed cleanup

polewskm

and

claude

committed

5b64ebc

Refuse a fetch time limit Node can't take: Infinity, fractions and values past int32

polewskm

and

claude

committed

bf333dd

Test the cleanup after a failed or timed-out fetch, and which trigger looks up the reviewed head

polewskm

and

claude

committed

cb5177b

Pin the default fetch time limit in a test, and drop a trailing blank line

polewskm

and

claude

committed

3362a68

Navigation Menu

Repository navigation

Follow up the engine fetch's review: a fetch time limit, a testable skip decision, sturdier tests - #22

Follow up the engine fetch's review: a fetch time limit, a testable skip decision, sturdier tests#22
polewskm merged 7 commits into
mainfrom
review-follow-ups

Commits on Oct 31, 2026

Follow up the engine fetch's review: a fetch time limit, a testable skip decision, and sturdier tests

Make the fetch's time limit testable and required, and take the skip decision in one place

Give git one options argument, and split the command and skip tests out

Look the reviewed head up only when it can matter, and log a failed cleanup

Refuse a fetch time limit Node can't take: Infinity, fractions and values past int32

Test the cleanup after a failed or timed-out fetch, and which trigger looks up the reviewed head

Pin the default fetch time limit in a test, and drop a trailing blank line