Repository navigation
Conversation
Replace the unused budgets.run with runCeiling(parts) = 8 + 4 x parts, overridable with CODE_REVIEW_MAX_RUN_USD. review() tracks the cost of its calls and skips reviewer and rule-check calls queued after the ceiling is reached, marking them skipped: run budget, while synthesis still runs on what was found and the summary warns.
There was a problem hiding this comment.
🤖 NCode Review at c6424e0: 7 new findings on the changed lines.
🤖 Review completeVerdict: 💬 Comment — This PR replaces the unused 8 reviewers run — 4 findings (run details)
Skipped: api-compat, data-model, infrastructure, performance, security Findings
Trial: findings are posted as review threads and in the check run. $0.52 on Amazon Bedrock, 60s, at 773338f. (how to interact) |
…(), no-findings and blocker verdicts, and a failed-plus-skipped reviewer
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 686620e: 4 new findings on the changed lines.
1 more was already posted on this pull request.
|
Autopilot: answering #61 (comment)
|
|
Autopilot: Round 2 answered. No blocker or should-fix is left open; the remaining threads are nits, answered above. Recommend merging once you've resolved them. |
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 773338f: 2 new findings on the changed lines.
2 more were already posted on this pull request.
# Conflicts: # CHANGELOG.md # README.md # src/config.ts # src/review.ts
|
Autopilot: merged
If verification should also stop at the ceiling, that's a follow-up. |
Replaces the unused
budgets.runwith a per-review cost ceiling,runCeiling(parts) = 8 + 4 × parts($12 for one part, $32 for six), overridable withCODE_REVIEW_MAX_RUN_USD.review()tracks the cost of every call so far and skips each reviewer or rule-check call queued after the total reaches the ceiling. Those reviewers showskipped: run budgetin the check run andskippedin the summary comment. Synthesis still runs on what was found, and the summary warns, also as a::warning::in the log. Unit tests stub the agent's costs. The README documents the variable.Decisions:
CODE_REVIEW_MAX_RUN_USDmust be a plain positive decimal (12,2.5). Any other value, including0, a negative number or1e3, warns and keeps the default.approveverdict becomescomment.ran, withN of M calls skipped: run budget.review()andselectContext()take an optional agent function, which defaults torunAgent, so tests can stub the calls.Closes #50