Repository navigation
Conversation
A missing test is should-fix only when the untested path is new behavior with a plausible user-visible failure and nothing below it covers it. Eval concerns can name a minSeverity, and five cases from #30 check both sides of the line.
There was a problem hiding this comment.
🤖 NCode Review at 1840ef6: 5 new findings on the changed lines.
🤖 Review completeVerdict: ✅ Approve — No findings. 5 reviewers run — 0 findings (run details)
Skipped: api-compat, architecture, completeness, data-model, infrastructure, performance, security, tests Trial: findings are posted as review threads and in the check run. $0.31 on Amazon Bedrock, 30s, at 502f569. (how to interact) |
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 7aa264e: 1 new finding on the changed lines.
2 more were already posted on this pull request.
|
Autopilot: answering the review summary at #65 (comment)
|
|
Autopilot: Round 2 answered. No blocker or should-fix is left open; the remaining threads are nits, answered above. Recommend merging once you've resolved them. |
# Conflicts: # CHANGELOG.md
Calibrates test-gap severity in the specialist prompt, the
testscharter and synthesis: a missing test is should-fix only when the untested path is new behavior with a plausible user-visible failure and no test below it covers it; a wrapper over tested pieces, a test that only pins current behavior, or a second test for a covered path is a nit.Eval concerns can now name a
minSeverity(judged only against findings at that severity or above), and five cases from #30 cover both sides: two expected should-fixes (the inline newest-summary choice at 1c8c1bd, the unasserted POST body at 9f052ed) and the three threads cited in the issue as must-not-be-should-fix.The paid eval (
npm run eval) was not run;npm run typecheckandnpm testpass.Decisions:
minSeverity: should-fix, so the bot may still raise these gaps as nits; the eval would otherwise forbid them outright.Closes #37