Repository navigation
Conversation
…tion-file sources apply to Training records each instruction file's applyTo with its extracted rules and tags a guidance bullet learned only from instruction files with their globs, generalized to any repository (src/**/*.cs becomes **/*.cs). The engine drops tagged bullets that match no changed file, and each part of a large diff gets only the bullets for its files. node training/run.ts --retag rewrites the tags without a model. Refs #36
Generated by node training/run.ts --retag: rules learned only from Identity's C# instruction files now apply to **/*.cs. Refs #36
![ncode-review[bot]](https://avatars.githubusercontent.com/u/12114478?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 NCode Review at df3325b: 7 new findings on the changed lines.
🤖 Review completeVerdict: 💬 Comment — This PR records an instruction file's applyTo globs when rules are extracted, tags each learned guidance rule that comes only from instruction files with 8 reviewers run — 5 findings (run details)
Skipped: api-compat, data-model, infrastructure, performance, security Findings
Trial: findings are posted as review threads and in the check run. $1.00 on Amazon Bedrock, 92s, at 2cd3885. (how to interact) |
# Conflicts: # CHANGELOG.md # training/run.ts
…format in one module review() builds its reviewer calls with reviewJobs and names its outcomes with outcomeNames, and extract() decides reuse with reuseExtraction, so tests cover them without a model: each part gets only its files' rules, an emptied rule batch doesn't run or report, and a changed or removed applyTo is saved without re-extracting. Also tests multi-glob tags, a topic with no bullets left, and retag refusing a malformed bullet. formatBullet, parseBullet and bulletGlobs move to src/guidance.ts and share one pattern for the Applies to field, so training and the engine can't drift apart on the layout.
|
/review |
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
🤖 NCode Review at 00418a4: 5 new findings on the changed lines.
Not on a changed line:
- 🟡 F4 Nit: No test runs the
--retagfile looptraining/run.ts:402. Tests coverretagGuidance, but notretag(), which loops over the folders, skips missing ones and writes files back. Fix: Optional: makeretagtake directories, then add a temp-folder test that asserts a stale tag is rewritten and an up-to-date file is left alone.
…bulletGlobs reads a tag after a Note
|
Autopilot: answering F4 (No test runs the declined: nit; |
|
Autopilot: Round 2 answered. No blocker or should-fix is left open; the remaining threads are nits, answered above. Recommend merging once you've resolved them. |
There was a problem hiding this comment.
🤖 NCode Review at 2cd3885: 3 new findings on the changed lines.
2 more were already posted on this pull request.
# Conflicts: # CHANGELOG.md
# Conflicts: # README.md # src/review.ts # test/engine.test.ts # training/run.ts
# Conflicts: # README.md # src/review.ts
|
Autopilot: Round 3 answered. The review-round limit (3) is reached; no blocker or should-fix showing a real defect is left open. The three new threads (a test for |
# Conflicts: # CHANGELOG.md # src/context.ts # training/run.ts
Each learned guidance bullet that came only from instruction files now carries their globs as a tag (
*Applies to:* `**/*.cs`). The engine drops tagged bullets that match no changed file, and each part of a large diff gets only the bullets for its files, so a C# rule no longer reaches a TypeScript review. Untagged bullets still apply everywhere.Training saves each instruction file's
applyTowith its extracted rules and writes the tags through one formatter.node training/run.ts --retagrewrites the tags without calling a model, and it regenerated the committedguidance/(87 bullets are now**/*.cs). A test fails when the committed guidance drifts from its sources.Decisions:
src/**/*.csandtests/**/*.csboth become**/*.cs.**, the bullet stays untagged and applies everywhere, as before. This keeps more rules in reviews rather than fewer.applyTovalues to the 10 committedtraining/extracted/.../instructions/*.jsonfiles by hand, using Identity's current instruction frontmatter. A later extract run keeps them in sync without re-extracting.Closes #36