Repository navigation
Bound Slurm evidence collector resources and add a liveness probe - #114
Merged
Merged
Conversation
The Slurm evidence collector DaemonSet set no resources, so it ran as BestEffort on the same nodes as Slurm jobs, and it had only a readiness probe, so a hung collector was marked unready but never restarted. Add slurmEvidenceCollector.resources with conservative defaults (requests 50m CPU / 64Mi, limits 500m CPU / 256Mi), rendered when set and omitted when set to null, and a livenessProbe on the existing /healthz endpoint. Add a chart-render test for the defaults, overrides, and omission. Refs #109 Signed-off-by: Selvanayaki Gurusamy <354650042+SelvanayakiGurusamy@users.noreply.github.com>
Assert only explicitly supplied resource quantities, retain null-resource coverage, and name the test for the rendered liveness configuration it checks. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
Member
Author
|
@coderabbitai review |
Action performed
|
Remove unvalidated default requests and limits and the unsupported workload co-location claim. Preserve resource passthrough and the HTTP liveness probe, and verify that default renders omit resource sizing. Signed-off-by: Rohan Adwankar <39285979+RohanAdwankar@users.noreply.github.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the implementation from PR #111 together with the reviewed test cleanup. Add configurable collector resource requests and limits and an HTTP liveness probe. Test explicit resource overrides and resources:null without pinning chart defaults, and describe the render test accurately. Validation: three targeted Slurm render tests, two collector behavior tests and Helm lint passed; the branch merges cleanly with current main.
Summary by CodeRabbit
nullomits the resource configuration while keeping the liveness check enabled.