Skip to content

Add ViDoRe v3 HR retrieval evaluation notebook - #2763

Merged
ChrisJar merged 5 commits into
NVIDIA:mainfrom
ChrisJar:codex/vidore-v3-hr-notebook
Oct 8, 2026
Merged

ChrisJar merged 5 commits into
NVIDIA:mainfrom
ChrisJar:codex/vidore-v3-hr-notebook

Conversation

@ChrisJar

@ChrisJar ChrisJar commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Add examples/vidore_v3_hr.ipynb, a compact example for ingesting the ViDoRe v3 HR corpus and computing page-level Recall and nDCG at 1, 3, 5, and 10.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Chris Jarrett <cjarrett@nvidia.com>
Signed-off-by: Chris Jarrett <cjarrett@nvidia.com>
This reverts commit ed72381.

Signed-off-by: Chris Jarrett <cjarrett@nvidia.com>
Signed-off-by: Chris Jarrett <cjarrett@nvidia.com>
@ChrisJar
ChrisJar marked this pull request as ready for review October 5, 2026 19:55
@ChrisJar
ChrisJar requested review from a team as code owners October 5, 2026 19:55
@ChrisJar
ChrisJar requested a review from charlesbluca October 5, 2026 19:55
Comment thread examples/vidore_v3_hr.ipynb Outdated
"import sys\n",
"\n",
"LOCAL_MODELS = True\n",
"INSTALL_DEPENDENCIES = True\n",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook tells users to choose Run All Cells, and this flag defaults to True, but this cell replaces Torch/Torchvision and then execution immediately continues into imports and GPU work in the same kernel. On every later Run All it also repeats the uninstall/reinstall. That makes the documented happy path unreliable and unnecessarily expensive. Please default installation to False and make the one-time setup an explicitly separate step, or stop execution after installation with a clear restart instruction.

Comment thread examples/vidore_v3_hr.ipynb Outdated
"else:\n",
" print(\"Reusing the existing index.\")\n",
"\n",
"assert index.open_table(TABLE_NAME).count_rows() > 0, \"Empty index: set OVERWRITE_INDEX=True.\"\n",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only verifies that some rows exist. If extraction skips pages, a prior run wrote only part of the corpus, or the cached table belongs to an older corpus snapshot, the notebook will silently compute plausible-looking metrics against an incomplete index. Because this pipeline promises exactly one vector per exported page, please validate count_rows() == len(corpus) before reuse; otherwise fail with the rebuild instruction.

Signed-off-by: Chris Jarrett <cjarrett@nvidia.com>
@ChrisJar
ChrisJar merged commit a42e90e into NVIDIA:main Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants