Skip to content

docs: restore Hermes variant page structure - #11926

Merged
jyaunches merged 1 commit into
mainfrom
codex/fix-main-docs-variants
Sep 16, 2026
Merged

jyaunches merged 1 commit into
mainfrom
codex/fix-main-docs-variants

Conversation

@jyaunches

@jyaunches jyaunches commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Restore the Hermes quickstart and Ollama page structure that commit 755f28d accidentally removed, while retaining its Portable Ollama guidance.

Why

Main's CI / Main Branch run fails two CLI shards because the affected MDX pages no longer start with YAML frontmatter and the Hermes quickstart lost its managed-image onboarding contract.

Changes

  • Restore the deleted Hermes quickstart prefix before the new Portable Ollama accordion.
  • Restore the Ollama page frontmatter and prerequisites before the Hermes-only Portable Ollama section.

Verification

  • npm exec -- vitest run --project integration test/generation/agent-variant-docs.test.ts
  • npm exec -- vitest run --project integration test/onboarding/onboard-managed-image-buildless-e2e.test.ts
  • npm run docs
  • git diff --check
  • Independent documentation review: no blockers or suggestions

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

  • Documentation
    • Added a Hermes-specific NemoClaw quickstart covering installation, onboarding, sandbox setup, dashboard and terminal access, inference, optional services, observability, and recovery guidance.
    • Added Ollama setup documentation covering prerequisites, supported agent variants, installation, and inference.
    • Documented NemoClaw’s ability to detect and manage Ollama on supported systems.

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f3072c79-854e-4d6e-8f7f-76c9ef5b4289

📥 Commits

Reviewing files that changed from the base of the PR and between 2fd6903 and c28c3c3.

📒 Files selected for processing (2)
  • docs/get-started/quickstart-hermes.mdx
  • docs/inference/set-up-ollama.mdx

📝 Walkthrough

Walkthrough

Changes

The PR adds a Hermes-specific NemoClaw quickstart and an Ollama setup page. The documentation covers installation, onboarding, sandbox launch, integrations, observability, scripted workflows, and local inference prerequisites.

NemoClaw documentation

Layer / File(s) Summary
Hermes onboarding flow
docs/get-started/quickstart-hermes.mdx
Adds Hermes metadata, starter-agent guidance, interactive installation, deferred onboarding, sandbox readiness checks, dashboard access, and launch commands.
Hermes integrations and automation
docs/get-started/quickstart-hermes.mdx
Adds provider, tool, messaging, Langfuse, credential, host restriction, key rotation, scripted onboarding, and troubleshooting guidance.
Ollama setup guidance
docs/inference/set-up-ollama.mdx
Adds Ollama metadata, supported agent variants, local inference guidance, and prerequisites for NemoClaw and host Ollama availability.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Suggested reviewers: miyoungc

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-main-docs-variants

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@jyaunches
jyaunches marked this pull request as ready for review September 16, 2026 16:44
@jyaunches
jyaunches merged commit fc8a179 into main Sep 16, 2026
33 of 34 checks passed
@jyaunches
jyaunches deleted the codex/fix-main-docs-variants branch September 16, 2026 16:45
cv pushed a commit that referenced this pull request Sep 17, 2026
## Outcome

Initial cleanup in Pi qualification, agent-turn latency, and
sessions/agents CLI E2E checks the named OpenShell gateway before
deleting a sandbox. A verified absent registration lets onboarding
proceed. Failed or ambiguous observations and terminal cleanup failures
remain errors.

## Reason

Main E2E run 35087621077 failed these jobs before onboarding because a
fresh runner had no `nemoclaw` gateway. The fixtures handled an absent
sandbox but not an absent gateway.

## Changes

- Add a shared gateway observation to `SandboxClient`. It accepts only
complete, ordered missing-registration guidance from the pinned
gateway-info command.
- Use that observation in the three initial cleanup paths. Preserve
strict terminal cleanup and forward cleanup.
- Resolve the latency cleanup gateway once, so inspection and
registration removal use the same name when `OPENSHELL_GATEWAY`
overrides it.
- Cover malformed, incomplete, repeated, reordered, failed, timed-out,
and signaled observations; gateway overrides; and cleanup ordering.
- Map Pi qualification to the shared cleanup-client regression suite.

## Verification

Candidate: `fcef6f7b17abdf8b18c5fe178975accd7f4ab43e`. Integrated
trusted main: `8657616c8171de9371f80c6c1cdaf93f54dffb09`.

- 196 focused tests passed across `e2e-clients`,
`agent-turn-latency-progress`, and `agent-variant-docs`. Command:
`node_modules/.bin/vitest run --project e2e-support --project
integration test/e2e/support/e2e-clients.test.ts
test/e2e/support/agent-turn-latency-progress.test.ts
test/generation/agent-variant-docs.test.ts --testTimeout 120000`. The
explicit timeout accommodates cold imports.
- Normal commit hooks passed, including formatting, lint, repository
checks, E2E phases, source-shape and growth budgets, secret scanning,
and commitlint.
- The former shard 4 and 12 documentation failures were inherited.
Merged repairs #11908 and #11926 are integrated; the retained
documentation test passes.
- The diff contains no secrets, API keys, or credentials.

Normal pre-push publication validation and JavaScript/CLI type-checks
passed with `NODE_OPTIONS=--max-old-space-size=8192`. GitHub verified
every PR commit. Latest-commit CI and selected trusted E2E results are
being collected; those gates remain pending.

## Review notes

Alternative review completed for the candidate above. Both CodeRabbit
findings and the matching maintainer change request were repaired with
protecting tests. The full seven-file diff was reviewed for correctness,
gateway identity, absence classification, error propagation, cleanup
ordering, and coverage.

The local Docker Advisor used trusted main, pinned OpenShell 0.0.116,
Landlock, and an isolated controller. It failed before its first
specialist: the pinned Pi image pull reported `no space left on device`
in the shared VM. No specialist completed. The task sandbox, gateway,
controller, and failed cache were cleaned up without stopping other
tasks. This is self-review supplemented by the existing CodeRabbit and
human findings, not Advisor clearance or independent review.

Selected E2E: `cloud-onboard`, `cloud-inference`, `security-posture`,
`pi-agent-qualification`, `agent-turn-latency`, and
`sessions-agents-cli`.

---
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved sandbox cleanup reliability by verifying the configured
gateway before attempting deletion.
- Missing gateways are handled safely, while malformed, unexpected,
timed-out, or failed checks are surfaced.
- Sandbox destruction continues even when gateway cleanup cannot
proceed.
  - Standardized pre-onboarding cleanup across end-to-end workflows.
- Cleanup now respects configured gateway names and verifies cleanup
ordering.

- **Tests**
- Expanded coverage for gateway detection, custom gateway names, cleanup
ordering, timeout behavior, failure handling, and deletion errors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@wscurran wscurran added area: docs Documentation, examples, guides, or docs build area: providers Inference provider integrations and provider behavior chore Build, CI, dependency, or tooling maintenance integration: hermes Hermes integration behavior provider: ollama Ollama local model provider behavior labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build area: providers Inference provider integrations and provider behavior chore Build, CI, dependency, or tooling maintenance integration: hermes Hermes integration behavior provider: ollama Ollama local model provider behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants