Repository navigation
chore(deps): update OpenClaw to 2026.10.5 - #12382
Conversation
Patch-Walker-Manifest: sha256:8f02f4a58b35b10021a74ce9c687302a9955962b722a1eab2dd2cb2085b638a3 Patch-Walker-Action: sha256:3d286db0269406f5d7f4ca1498088b786bfdbdfcb2b7a5c5b7160f9284b9dd2a Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Patch-Walker-Manifest: sha256:cd4ca477a440a48a39bd27315b6a6feab12ca9b047314adf5c60232a18166aa0 Patch-Walker-Action: sha256:d872c43b48b28bb23f8c5a815ed81a7e95e4c760673a4ae98919600b890a18c9 Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Patch-Walker-Manifest: sha256:0bc3b7783ef39fb636ddaff4a2769d9a18b29140fa835bfbdbef18d32be4285a Patch-Walker-Action: sha256:3d286db0269406f5d7f4ca1498088b786bfdbdfcb2b7a5c5b7160f9284b9dd2a NemoPatch-Draft-Rebase: sha256:cc14a16725fe524469e3772b77626e607b690c4c239197456dfd2ee18807104e Previous-Head: 149296d Previous-Base: 3f98fc7 Previous-Action-Base: 241fcd1 Base-Commit: 4355902 Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Patch-Walker-Manifest: sha256:aefb923570aafcfac1dbcdf63668265d81ce9b7edbc337468c1e7deb9ca18ff8 Patch-Walker-Action: sha256:3d286db0269406f5d7f4ca1498088b786bfdbdfcb2b7a5c5b7160f9284b9dd2a NemoPatch-Draft-Rebase: sha256:89cafad604a83e50b8537d3d3355d9300cb54e11f632f0ac50d732cbf730f9dc Previous-Head: 9972df9 Previous-Base: 3f98fc7 Previous-Action-Base: 4355902 Base-Commit: 7e1310c Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
@coderabbitai review |
|
@coderabbitai review |
|
@coderabbitai review |
|
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Keep the original CodeQL analysis identities while Python runs independently. Use the storage bridge fixture seam and prepare verified executable-directory permissions before historical hosted-runner upgrades. Preserve existing live assertions, runtime identity checks, migration backups and deadlines. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Keep extracted startup sections whole and supply their auth-only helper stubs. Preserve credential and gateway assertions. Keep transient step-down scripts within fixture HOME, with shell quoting for spaces. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Map restore and upgrade fixture inputs to their fast tests. Retain completed native readiness probes and bounded owner and worker facts before cleanup. Preserve lifecycle assertions, readiness deadlines, and runtime custody rules. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Apply the existing fresh native root lookup to the pinned 9.5 and 9.7 migration runtimes. Retain guarded file admission, exact source and dependency checks, offline materialization, backups, and migration passes. Local controlled profiling reduced the bridge phase by 2.7 seconds on Linux ARM64. The original 35-minute CI installer failure still requires qualification on the published repair. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
…e lookups Keep original alias and error resolution and every source identity, content, directory, dependency, and module lookup check. Verify the complete pinned native module before applying either patch. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Preserve rejected pairing field diagnostics alongside bounded observation retries and failure reasons. Retain upstream installer and runtime provenance changes. Full installer runtime qualification remains incomplete. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Resolved the four readiness conflicts against main Local checks: 164 readiness tests passed with seven existing skips; 58 runtime-provenance tests and 31 installer ACP contracts passed. Normal isolated commit/pre-push hooks, repository budgets and CLI type checking passed. The original installer harness failures are retained; system Git inside the same credential-denying sandbox corrected fixture-global-config interference without changing repository checks or timeouts. New source CI, image, CodeQL and scoped runtime checks are running. The latest Advisor evaluation and every scheduled specialist report still require collection. Prior candidate Four trusted-base workflows failed before creating any jobs: growth enforcement, upgrade admission, maintainer edits and issue assignment. Their files match main, and unrelated PRs show the same startup failure. GitHub reports a likely workflow-file issue, but the retrieved API supplies no detailed root cause. This requires maintainer investigation of trusted-base workflow/Actions configuration. No deterministic rerun or bypass was attempted. The original v0.0.123 installer still fails its unchanged 35-minute cap. Later storage, concurrency, channel and v0.0.89 passes remain scoped evidence; full DEFAULT79 qualification is incomplete. The older disputed Advisor P1 still needs independent adjudication. Scheduled monitoring remains paused, original retry budgets and backups remain intact, and Deep Agents Code remains NOT hardened. |
|
Independent review requested for Please adjudicate the older Advisor P1 Current source CI, image qualification, and all nine Advisor specialists passed. Their scoped results and limitations are in the PR description. The original runtime diagnostic still failed the v0.0.123 installer’s unchanged 35-minute cap. The remaining 73-case plan and full DEFAULT79 qualification remain incomplete. This review request does not claim those failures are fixed or seek a check waiver. Deep Agents Code remains NOT hardened. No merge is authorized. |
Consume the merged Model Router retirement and resolve its conflicts. Preserve the existing approved PR assertion allocation while lowering totals for the retired router test. Restore the dedicated survival plugin-turn allowance and make the clipped NIM diagnostic fixture hold through TERM. Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Resolve the read-count conflict in snapshot.test.ts with #12382: the managed OpenClaw sandbox no longer reads its OS, and neither sandbox reads the native roster, so the join test expects three reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Will Curran <wcurran@nvidia.com>
## Outcome JavaScript CodeQL completion now succeeds when its query partitions and combined report succeed, even if Python analysis fails, is cancelled, or is skipped. ## Reason Follow-up to #12382. Advisor finding `F-delivery-flow-b909ee3972ce3ae69299` identified an unrelated Python dependency in the JavaScript completion check. The existing state test incorrectly required Python success and preserved that coupling. ## Changes - Remove Python from the JavaScript aggregate dependencies and success condition. - Correct the existing 19 state combinations to require JavaScript query and publication success independently of Python. ## Verification - `node node_modules/vitest/vitest.mjs run --project integration test/repository/code-scanning-workflow.test.ts` — 30 tests passed under Node 24.22.1 in isolation. - Complete two-file diff inspected; Python analysis, JavaScript query coverage, SARIF publication, ShellCheck, permissions, and deadlines remain unchanged. - [Source CI](https://github.com/NVIDIA/NemoClaw/actions/runs/42861525438) — all 12 CLI shards and the coverage aggregate passed. - [Code scanning](https://github.com/NVIDIA/NemoClaw/actions/runs/42861525809) — all six jobs passed. - [Image qualification](https://github.com/NVIDIA/NemoClaw/actions/runs/42864162354) — AMD64/ARM64 production builds, OpenClaw security and glibc contracts, port overrides, and non-root smoke passed. - [PR Advisor](https://github.com/NVIDIA/NemoClaw/actions/runs/42865577968) — all nine specialists clear; all 27 reports reviewed; no additional E2E recommended. - The diff contains no secrets, API keys, or credentials. ## Review notes Sensitive path: `.github/workflows/code-scanning.yaml` in `NVIDIA/NemoClaw`. The author inspected published commit `f1ad11d5951c8588ad398a677bc338c055194336` against base `129527586eaede1d3b12aae44afb98e1d7375a33`, executed the workflow condition across the retained state cases, and confirmed independent Python analysis. This covers the same repository and changed paths. Independent review of the published commit is pending. --- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Bug Fixes** * JavaScript code-scanning results can now succeed when JavaScript checks and report publication pass, regardless of the Python job’s result. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Outcome
Upgrade managed OpenClaw and its official plugins from 2026.9.2 to 2026.10.5 while preserving state restoration, credentials, plugin provenance and sandbox isolation. Resolve conflicts with upstream main
009a4f1612, including the merged Model Router retirement, while retaining rejected-field diagnostics and bounded observation behavior. Prepared for independent review at the author’s request; full runtime qualification remains incomplete, and no merge is authorized.Reason
Adopt OpenClaw 2026.10.5 and repair lifecycle, messaging and startup incompatibilities found during qualification.
Changes
Update runtime/plugin locks, archive integrity, managed images, dependency remediation and WeChat 2.4.10 together. Preserve security pins and sender-denial controls.
Preserve original backups and pinned 2026.9.5/2026.9.7 migration bridges outside the ordinary runtime path. Retain downgrade, mixed-store, archival, ownership, rollback and recovery checks.
Repair native pairing, client-token publication and shutdown notification handling. Retain native ownership authority, bounded admission retries and startup holds on uncertain state. Keep original operation deadlines.
Restore a private Node compile cache outside the native home archive and propagate it to workers. Verify plugin roots through guarded native filesystem APIs with pinned implementation/dependency identities. Existing migration, startup and source-root regression tests protect these paths.
Preserve host-execution evidence and paired SQLite transcript checks for admitted plugin turns. Correct survival-session and llama.cpp fixture authority; keep restore/upgrade fast-test mappings and failure-preserving diagnostics.
Restore complete JavaScript CodeQL publication after both complementary query partitions finish; the workflow contract tests cover completion states and invalid report refusal. Refresh genuine Pi AMD64/ARM64 receipts with source parity, retain standalone configuration generation, and resolve observer assets directly within the architecture budget.
Merge upstream installer shim ownership, OpenShell runtime provenance and Model Router retirement. Resolve the ten integration conflicts while preserving upstream receipt authority and the approved assertion allocation. Aggregate assertion limits decrease with the retired router test; no new budget allocation or exception is added.
Restore the dedicated two-minute native plugin-turn allowance in sandbox survival, with an explicit numeric timeout parameter. Keep the existing readiness-probe, overall test and workflow deadlines.
Make the NIM clipped-diagnostic fixture refuse readiness and hold its simulated diagnostic through TERM until forced shutdown. Preserve the timeout, redaction and identity assertions.
Refresh both Pi qualification receipts from the successful
4181fc354aimage cohort and match their authority digests. Wait for accepted survival deletion to settle within its existing verification deadline; preserve cleanup ownership until absence is confirmed.Verification
Latest commit:
3695725be64a4481327134fc05cd1e2f151c91dc, integrating upstream main009a4f1612d376fad16324ea238e35010fc8bfe9.replayInvalid=true. These checks do not qualify replay validity or the legacy installer deadline. Deep Agents Code remains NOT hardened.3695725be6, using trusted controller009a4f1612. Its immutable receipt verifies empty selectors. The trusted plan has 78 coverage rows; all 60 catalogue jobs were generated. The installer test remains pending. Staging Brev and explicit-only hardware jobs are excluded.managed_image_revision=4181fc354ainput for the previously qualified ancestor images. The CLI and tests use3695725be6; image contracts retain their original revision and cohort. The separate current-image qualification passed as recorded above.Previous candidate
ab755477421a45b3689ebfa0133b63174dc13009, based on upstream main1d518c967cbce498fa93d4771964534bc25f2d66:4181fc354a. The strict production receipt checker returnsqualified; image-source parity and the exact receipt digests remain enforced.Deletingphase within the existing 60-second verification deadline. It retains the final absence assertion and keeps cleanup armed until that assertion succeeds. Five controlled scenarios using the actual changed source passed, including command failure and deadline exhaustion. No timeout or assertion limit increased.state-backup-restoreowner; it passed both scenarios in the completed full default suite, together with Pi qualification and sandbox survival. This is source-review evidence, not independent approval or a waiver of the deterministic E2E floor.replayInvalid=true; these checks do not qualify replay validity, the original installer deadline, or full-suite completion. Deep Agents Code remains NOT hardened.ab75547742with 80 successful jobs, 19 intended skips and two failures: the installer target and the derivativeRelevant E2Eaggregate. Its immutable dispatch receipt verifies the latest PR commit, trusted1d518c967ccontroller and empty selectors. The trusted plan contains 78 coverage rows; all 60 catalogue jobs were generated. The v0.0.123 installer job failed its unchanged 35-minute deadline. Protected runtime passed. The final aggregate reportscatalogue-github-readas the only unsuccessful selected workflow group, matching the installer failure.managed_image_revisioninput for qualified ancestor4181fc354a. All image build inputs are unchanged. The CLI and tests useab75547742; the image contracts retain their original revision and cohort. This does not qualify the separate current image build. Brev staging and opt-in hardware jobs are excluded.Deletingsettlement branch; five controlled source scenarios cover that branch.Previous candidate
4181fc354a:Deletingafter accepted deletion; the v0.0.123 installer exceeded its original 35-minute deadline in the third restored sandbox's 10.5 Doctor. The installer cause remains unresolved. No unchanged exhausted installer rerun was launched.28b9c8f74a6778ed56e5d4f94474007fb972abef288656b0959aa3fd374bff04. The repair adds no allocation or exception.The remaining verification results below are historical evidence for
57cabe80bcad53ff885493dce528acffd3186ce4, integrating main4d5d613f73. They do not qualify the latest commit.passed. DCO and commit verification:passed; GitHub Verified for the merge and all three included upstream commits.Historical candidate qualification for
57cabe80bc:ghrun-42662064951-1. AMD64, ARM64 and rootless Podman published-image activations each passed 13 phases and 13 cleanup callbacks. Their evidence contains 98, 98 and 100 command results respectively, each with matching stream files, 38 authenticated completion POSTs and zero local image-build commands. Two external-agent configs on each platform match the published configs; managed-agent catalog receipts are asserted by the owning test.Podman retained nine 45-second forced stops and runner cleanup of one catatonit and eight conmon processes. Final absence was verified for the five named test sandboxes after bounded settlement; graceful stop and global process absence remain unproved. The Ubuntu 26.04 host warning is retained. Image activation uses synthetic inference, and its external rebuild is 10.5 to 10.5. Native child receipts demonstrate successful tools but retain
replayInvalid=true; they do not qualify replay validity. Same-agent output files are overwritten during the external-image phase. These passes do not replace the original legacy installer deadline or full DEFAULT79 qualification.The five-row runtime diagnostic passed concurrency within its unchanged 60-second contract, channel stop/start with seven preserved projections, both storage tests and the v0.0.89 upgrade. The v0.0.123 installer failed its unchanged 35-minute cap. Post-upgrade restoration, stopped-sibling lifecycle, systemd replacement and upgraded credential custody remain unproved. All seven failure-cleanup callbacks passed. The remaining 73-case plan is unexecuted, and original DEFAULT79 obligations remain recorded. No unchanged exhausted retry was launched.
A separate native AMD64 confined timing profile completed all six Doctor passes and 17 bridge subprocess checks: restore took 71.8 seconds, and the workload took 585.9 seconds. Repeated plugin/config capture is expensive; cache flushes totalled 0.9 seconds. This diagnostic does not prove full installer completion or the exclusive cause of its timeout. Both copy comparisons passed 960 assertions, but batch copying was slower, so no copy-path change was made. Original archives and retained resources remain intact; owned diagnostic containers and sandboxes were removed.
Review notes
Independent approval and the older disputed Advisor router P1 adjudication remain required. For the historical
57cabe80bccandidate, four trusted-base workflows initially failed before creating jobs, and the original failures remain recorded. After the qualification-description update, growth enforcement, upgrade admission, maintainer edits and issue assignment completed successfully for the unchanged candidate. Growth ran all seven checks against the recorded head/base. The earlier startup cause remains unexplained; no retry, source change or bypass was used to obtain these passes. The historical full DEFAULT run failed; later scoped passes do not replace full runtime qualification. Staging qualification is outside the authorized DEFAULT79 scope. CodeRabbit is user-excluded; its skipped review is not approval and no check configuration changed. Scheduled CI monitoring is active.Sensitive paths include installer/runtime scripts, images, inference, onboarding, messaging, policy, workflows and E2E tooling. Retained source review and isolated hooks cover
ab75547742; current conflict checks are clear. Previous source CI and nine-specialist Advisor reports coverab75547742; its image qualification passed. For3695725be6, source CI, CodeQL and image qualification passed; Advisor requires the prepared delivery repair. The requested full E2E run is pending, and the previous installer failure remains unresolved. Historical evidence for earlier commits remains identified above. Independent maintainer acceptance of these sensitive changes remains outstanding. San owns landing. Deep Agents Code remains NOT hardened.Inherited host installer audit warnings remain disclosed: root 23 affected packages (two critical), plugin eight (two critical); locked affected entries match the previously audited trusted base. Production-only results were three moderate root reports and zero plugin reports. These historical counts do not waive full host audit warnings, and no automatic dependency fix or suppression was applied.
Detailed prior evidence and consumed retries remain in the qualification status record. Original authoring-session reports remain unchanged.
Signed-off-by: Prekshi Vyas prekshiv@nvidia.com