Repository navigation
ci(e2e): permit model-drift regression budget for PR 12769 - #12776
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe assertion-growth policy adds a proposed budget exception for PR ChangesAssertion Budget Exception
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete defect in this policy change is established. The exception’s intended use still depends on PR 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit ff792d0 in the Show a line coverage summary of the most impacted files.
TypeScript / code-coverage/cliThe overall line coverage in commit ff792d0 in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
## Outcome Renew the exact assertion-budget exception for PR #12769 after main reduced the concurrent-gateway assertion inventory. The exception continues to permit only the approved four-point increase for same-name OpenClaw model-change recreation. ## Reason The original prerequisite #12776 matched the previous whole-file budget hashes. Main's seven-assertion reduction in #12608 changed those hashes, so the exact-match guard correctly rejected the updated candidate. The changed-model regression contract has not expanded. ### Related issues Refs #12667. Prerequisite for #12769. ## Changes Update only PR #12769's base and candidate budget hashes and its explanation. Preserve all other exceptions, all assertion counts, and the exact PR identity and digest checks. Remove this exception after #12769 merges. ## Verification - Existing growth-guardrail parser tests: 58 passed, including exact-transition acceptance and rejection cases. - Independently computed hashes match canonical main `888e95d0ad01db264575181a620923e568c343c7` (budget unchanged from `c518e121d23c616da1b083c44c9eb504fb419ebd`) and PR candidate `a377d75342b1db1c6cbe230300373c14822ecd0a`; all sibling exception entries are unchanged. - `git diff --check` passed. The diff contains no secrets, API keys, or credentials. - Publication validation and CLI, plugin, and JavaScript configuration TypeScript hooks passed during the guarded normal push. --- Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated automated validation records to reflect a revised approved limit while preserving previously accepted adjustments. The records also clarify the conditions associated with the approval. These changes affect validation tracking only; they do not change product functionality or user-facing behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com> Co-authored-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Outcome
Permit PR #12769 to use one exact E2E assertion-budget transition after this policy reaches
main. All other PR numbers and budget contents remain subject to the existing growth gate.Reason
The model-drift regression needs a live same-name onboarding scenario that verifies replacement identity, OpenClaw's selected model, and the recorded selection. Seven new checks replace three redundant checks, adding four assertion points. The independent gate reads policy from the trusted base, so this entry must land before the test update.
Related issues
Refs #12667. Prerequisite for #12769.
Changes
fdc4a78b5588629e26b00778d1bc82d69101077b9e372f2b58670510184579c2to469755f2243b45762eca7b26c869eb03d9c2cb6cab6b9a2c55fbcda0c78f884e.double-onboardbudget change from[36,43,36,43,0]to[42,47,42,47,0]and removal after fix(onboard): check selection drift before fresh sandbox reuse #12769 merges. Other file budgets remain unchanged.Verification
growth-guardrail-parsers.test.ts: 58 tests passed.Review notes
This is a proposed trusted policy entry requiring normal maintainer review and branch protections. No CI waiver is requested. The dependent E2E change remains uncommitted and has not run live. Self-review verified the exception's PR and digest restrictions; independent review is pending.
Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com
Summary by CodeRabbit