Repository navigation
Conversation
Two coordinated changes so the timeout bump actually takes effect: 1. test/cli.test.ts: runWithEnv default timeout 10000 -> 30000. The CLI cold-starts a Node child for each test case via execSync. Under modest CPU contention on a self-hosted runner, 10s isn't enough — several tests would intermittently abort with ETIMEDOUT from execSync itself rather than from a real test failure. 2. vitest.config.ts: add testTimeout: 30_000 and hookTimeout: 30_000 to the cli project. Vitest's default testTimeout is 5000ms, which would abort tests long before the 30s execSync ceiling — making the bumped child timeout useless on slow CI hosts. Salvaged from #1627 Originally authored by @TSavo. Rebased onto main after the TS migration renamed cli.test.js -> .ts. Closes #1621 (sub-item 1 of three). Co-Authored-By: TSavo <TSavo@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTest execution timeouts increased to 30 seconds across the CLI test suite. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Actually don't think I want to do this. Bumping test timeouts can mask unnecessarily slow tests. |
Summary
Salvaged from #1627 by @TSavo (fork returned 503, could not push there).
test/cli.test.ts: bumprunWithEnvdefaulttimeoutfrom 10s to 30svitest.config.ts: addtestTimeout: 30_000andhookTimeout: 30_000to thecliproject so Vitest's per-test ceiling matches theexecSynctimeoutThe TS migration renamed
test/cli.test.jstotest/cli.test.ts; the timeout change was applied to the new filename. The vitest.config.ts comment was also updated to reference.ts.Closes #1621 (sub-item 1 of three).
Test plan
vitest run test/cli.test.ts-- 44/44 tests passCo-authored-by: @TSavo
Summary by CodeRabbit