refactor(snapshot): remove Kubernetes image probe by ericksoa · Pull Request #6811 · NVIDIA/NemoClaw

ericksoa · 2026-07-13T23:47:11Z

Summary

Removes the snapshot restore path that entered the OpenShell gateway container and invoked kubectl to rediscover the source image.

This is PR 16 of 21 in the OpenShell gRPC migration stack.

Changes

Treat the image recorded from OpenShell sandbox creation as the authoritative rebuild input for every driver.
Fail closed for legacy registry entries that do not record an image.
Delete the Docker-to-kubectl pod image probe and its fixture behavior.
Remove the snapshot site from the reviewed legacy Docker-exec inventory.

This slice removes 73 lines and adds 16.

Stack

Stack index: refactor(openshell): establish sandbox control boundary #6790
Depends on: refactor(openshell): unify CLI exec capture #6809
Review this PR against base branch refactor/openshell-unify-cli-exec/ae to see only this slice.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Quality Gates

Existing tests cover changed behavior — justification: snapshot unit, existing-destination, gateway guard, and legacy-transport inventory tests cover successful and missing-image paths.
Existing tests cover changed behavior — justification:
Tests not applicable — justification:
Docs not applicable — justification: this slice changes only internal snapshot transport behavior and tests.
Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: transport-boundary self-review completed; missing durable image metadata now fails closed instead of bypassing OpenShell through Docker.
Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
Targeted behavior tests pass for the current change set, or tests are marked not applicable above — build plus 65 snapshot and inventory tests passed
Applicable broad gate passed — npm run check:diff passed at 7115ff24
Quality Gates section completed with required justifications or waivers
No secrets, API keys, or credentials committed
npm run docs builds without warnings (doc changes only) — not applicable
Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

coderabbitai · 2026-07-13T23:47:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c97a3864-8da3-471d-9a98-82026cb53628

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch refactor/openshell-remove-snapshot-kubectl-probe/ae

_{Comment @coderabbitai help to get the list of available commands.}

github-code-quality · 2026-07-13T23:47:52Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the refactor/openshell-u... branch.

TypeScript / code-coverage/cli

The overall coverage in the refactor/openshell-r... branch remains at 79%, unchanged from the refactor/openshell-u... branch.

Show a code coverage summary of the most impacted files.

File	`refactor/openshell-u...` 5b67372	`refactor/openshell-r...` 0b3695e	+/-
`src/lib/onboard...tup-nim-vllm.ts`	89%	71%	-18%
`src/lib/onboard.ts`	30%	29%	-1%
`src/lib/diagnostics/debug.ts`	14%	29%	+15%
`src/lib/adapter...teway-config.ts`	0%	77%	+77%
`src/lib/adapter...dbox-control.ts`	0%	78%	+78%
`src/lib/state/s...tore-payload.ts`	0%	83%	+83%
`src/lib/adapter...dbox-control.ts`	0%	94%	+94%
`src/lib/adapter...trol-routing.ts`	0%	97%	+97%
`src/lib/adapter...ndbox-upload.ts`	0%	99%	+99%
`src/lib/actions...store-source.ts`	0%	100%	+100%

_{Updated July 15, 2026 06:33 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

github-actions · 2026-07-13T23:51:57Z

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: onboard-repair, onboard-resume, state-backup-restore, upgrade-stale-sandbox

3 optional E2E recommendations

snapshot-commands
sandbox-operations
tunnel-lifecycle

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

apurvvkumaria

Reviewed exact stacked head 0b3695e against base 7a3d3ff. Snapshot clone/restore now reads the source image through the authenticated OpenShell descriptor, validates route/name/id/image, samples twice around all destructive preflight, rejects observed drift, and never bypasses OpenShell through Docker/Kubernetes. Verified all 10 commits are GitHub Verified, no unresolved threads/advisor findings, repository CI including protected E2E is green, CLI build passed, and focused source/lifecycle/integration coverage passed locally (60/60).

## Summary Makes the supported OpenShell sandbox exec API the sole path for graceful in-sandbox gateway shutdown. This is PR 17 of 21 in the OpenShell gRPC migration stack. ## Changes - Delete Docker gateway-container discovery and kubectl pod selection. - Delete the privileged kubectl exec shutdown attempt. - Run the existing identity-guarded stop script through gateway-scoped `openshell sandbox exec` only. - Remove both shutdown sites from the reviewed legacy Docker-exec inventory. This slice removes 161 lines and adds 13. ## Stack - Stack index: #6790 - Depends on: #6811 - Review this PR against base branch `refactor/openshell-remove-snapshot-kubectl-probe/ae` to see only this slice. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Existing tests cover changed behavior — justification: gateway-stop, sandbox-stop, and service lifecycle tests cover success, already-stopped, missing CLI, gateway routing, and error reporting. - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [x] Docs not applicable — justification: this slice changes only internal shutdown transport behavior and tests. - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: transport-boundary self-review completed; the existing identity-guarded stop script is unchanged and now runs only through the supported OpenShell API. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — build plus 67 gateway-stop, sandbox-stop, and service lifecycle tests passed - [x] Applicable broad gate passed — `npm run check:diff` passed at `f44c32ae` - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — not applicable - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Aaron Erickson <aerickson@nvidia.com> --------- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

ericksoa · 2026-07-23T22:13:23Z

Closing as superseded: NemoClaw will consume the upstream OpenShell TypeScript SDK from NVIDIA/OpenShell#2122 instead of maintaining this raw gRPC/proto transport stack.

ericksoa added 2 commits July 13, 2026 16:36

refactor(openshell): unify CLI exec capture

64e5e67

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

refactor(snapshot): remove Kubernetes image probe

7115ff2

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

ericksoa mentioned this pull request Jul 13, 2026

refactor(openshell): establish sandbox control boundary #6790

Closed

10 of 20 tasks

ericksoa mentioned this pull request Jul 13, 2026

refactor(openshell): remove gateway-stop kubectl path #6812

Merged

11 of 20 tasks

ericksoa added 10 commits July 13, 2026 18:06

chore(stack): carry snapshot failure diagnostics

5a7ad4f

chore(stack): carry snapshot failure diagnostics

8237782

chore(stack): carry snapshot stdin fixture fix

e6b48f7

chore(stack): carry snapshot stdin fixture fix

48deddf

chore(stack): carry snapshot restore diagnostics

0df8262

chore(stack): carry snapshot restore diagnostics

986c284

chore(stack): carry OpenShell config isolation fix

8c9bc0e

chore(stack): carry OpenShell config isolation fix

79c9c5a

chore(stack): carry read-only gRPC fallback

febe2a6

chore(stack): carry read-only gRPC fallback

6d7fba0

wscurran added area: architecture Architecture, design debt, major refactors, or maintainability area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery refactor PR restructures code without intended behavior change labels Jul 14, 2026

ericksoa added 9 commits July 14, 2026 21:23

chore(stack): follow reviewed share transport head

abbc249

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

feat(openshell): read sandbox descriptors over gRPC

19b0a67

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

refactor(snapshot): read source image over gRPC

013b6f9

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

test(snapshot): bound descriptor preload seam

6ebca2c

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

ci: retry PR advisor analysis

7a3d3ff

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

chore(stack): follow final descriptor preload head

2c37978

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

refactor(snapshot): pin live restore source descriptors

77e6553

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

test(snapshot): keep descriptor checks linear

7d78a80

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

fix(snapshot): describe source recheck boundary

0b3695e

Signed-off-by: Aaron Erickson <aerickson@nvidia.com>

apurvvkumaria self-assigned this Jul 19, 2026

apurvvkumaria approved these changes Jul 19, 2026

View reviewed changes

Base automatically changed from refactor/openshell-unify-cli-exec/ae to refactor/openshell-collapse-sshfs-compat/ae July 20, 2026 20:49

ericksoa closed this Jul 23, 2026

Navigation Menu

Repository navigation

refactor(snapshot): remove Kubernetes image probe - #6811

refactor(snapshot): remove Kubernetes image probe#6811
ericksoa wants to merge 22 commits into
refactor/openshell-collapse-sshfs-compat/aefrom
refactor/openshell-remove-snapshot-kubectl-probe/ae

ericksoa commented Jul 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

Review skipped

Uh oh!

github-code-quality Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

apurvvkumaria left a comment

Uh oh!

ericksoa commented Jul 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ericksoa commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Stack

Type of Change

Quality Gates

Verification

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-code-quality Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

github-actions Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review Advisor — Informational

Model lanes

E2E guidance

Uh oh!

apurvvkumaria left a comment

Choose a reason for hiding this comment

Uh oh!

ericksoa commented Jul 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ericksoa commented Jul 13, 2026 •

edited

Loading

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

github-code-quality Bot commented Jul 13, 2026 •

edited

Loading

github-actions Bot commented Jul 13, 2026 •

edited

Loading