Skip to content

ci(images): allow base publisher to finish - #7512

Merged
senthilr-nv merged 2 commits into
NVIDIA:mainfrom
senthilr-nv:codex/fix-base-image-publisher-timeout
Jul 25, 2026
Merged

senthilr-nv merged 2 commits into
NVIDIA:mainfrom
senthilr-nv:codex/fix-base-image-publisher-timeout

Conversation

@senthilr-nv

@senthilr-nv senthilr-nv commented Jul 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The OpenClaw base-image publisher now has 90 minutes to complete instead of 45 minutes. The previous limit canceled the arm64-emulated Perl test suite while its tests were still passing.

Changes

  • Increase the base-image publication job timeout from 45 to 90 minutes.
  • Keep the existing build, test, and publication steps unchanged.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification: The change updates one GitHub Actions timeout value. Run 30135226357 reproduces cancellation at the previous limit while the build tests were passing.
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: The change does not alter a user workflow, configuration, or supported behavior.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: The failed base-image publication run shows the OpenClaw build continuing to pass Perl tests until GitHub canceled it at 45 minutes. The diff changes only the job timeout.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: The timeout is an internal CI execution limit. It does not change user workflows, configuration, or supported behavior.
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npm run test:changed exited 0 and reported no mapped source tests; the timeout-only change is verified by the failed publication run.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

@senthilr-nv senthilr-nv self-assigned this Jul 25, 2026
@coderabbitai

coderabbitai Bot commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The base image workflow’s build-and-push job timeout increases from 45 to 90 minutes.

Changes

Base Image Workflow

Layer / File(s) Summary
Build-and-push timeout
.github/workflows/base-image.yaml
Increases the build-and-push job timeout from 45 to 90 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: cv, ericksoa

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: extending the base image publisher timeout so the job can finish.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@senthilr-nv senthilr-nv added area: packaging Packages, images, registries, installers, or distribution area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery chore Build, CI, dependency, or tooling maintenance platform: container Affects Docker, containerd, Podman, or images security v0.0.95 labels Jul 25, 2026
@github-actions

github-actions Bot commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections match; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@senthilr-nv
senthilr-nv requested review from cjagwani and cv July 25, 2026 00:55

@cjagwani cjagwani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@senthilr-nv
senthilr-nv enabled auto-merge (squash) July 25, 2026 01:06
@senthilr-nv
senthilr-nv disabled auto-merge July 25, 2026 01:09
@apurvvkumaria

Copy link
Copy Markdown
Collaborator

Runner-stability dependency: this clean, approved timeout change is the publication prerequisite for the optimized Hermes base in #7492. Landing #7512 before the final #7492 main sync avoids publishing the reduced image under the known 45-minute cancellation budget. No code overlap exists between the two PRs.

@senthilr-nv
senthilr-nv merged commit 2f6298e into NVIDIA:main Jul 25, 2026
71 of 75 checks passed
@wscurran wscurran added area: security Security controls, permissions, secrets, or hardening and removed security labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: packaging Packages, images, registries, installers, or distribution area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery area: security Security controls, permissions, secrets, or hardening chore Build, CI, dependency, or tooling maintenance platform: container Affects Docker, containerd, Podman, or images

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants