[politerealism]

Summary

Move the three sandbox create --upload tests from the legacy e2e crate into the testkit conformance suite. The behavior isn't driver-specific, so it runs against any prepared gateway. Add ExecOutput::success and Sandbox::sh to testkit so the tests don't hand-write the exit-code check and the sh -c wrapper.

Related Issue

Contributes to #3954. No separate issue: this migrates existing coverage.

Changes

• Add ExecOutput::success(), matching CliOutput::success(), and a public command field so the failure message names the command. Add Sandbox::sh(script), which runs sh -c.
• Add tests/suites/conformance/tests/create_upload.rs with three tests, keeping the original names so filters keep working: create_with_upload_directory_preserves_source_basename, create_with_multiple_uploads and create_with_upload_single_file.
• Verify uploads by reading files back with Sandbox::sh and comparing exact content. The originals matched the printed output of sandbox create.
• Check the nested file in the directory test, and that the directory isn't flattened into the destination. Check each destination separately in the multiple-uploads test.
• Use the default upload path. The originals passed --no-git-ignore, which isn't needed outside a Git work tree and hid the default path.
• Create the sandbox from the target's default image. The originals used the e2e test image.
• Drop the claim that files arrive before the command runs. The CLI rejects --upload together with a command, so each test checks the files once create returns, and the module doc notes the limitation.
• Delete e2e/rust/tests/upload_create.rs and the now-unused SandboxGuard::create_with_upload and create_with_uploads from the legacy harness.
• Add a create-upload row to the conformance README.

main has no end-to-end coverage of sandbox create --upload outside the legacy test this PR removes. crates/openshell-cli has integration tests for the planning and error paths, but they stub the gateway and SSH transport. tests/suites/conformance/tests/file_transfer.rs covers the separate sandbox upload command. None of them check directory basenames, multiple uploads or a single-file upload on a real sandbox.

Testing

• mise run pre-commit passes on both commits
• cargo clippy --tests is clean in tests/suites/conformance
• The three tests against a local Docker gateway. Not run yet.
• Conformance in the CI lanes (test:e2e). Not run yet.
• Not run: macOS.

Checklist

• Follows Conventional Commits
• Commits are signed off (DCO)
• Architecture docs updated (not applicable)

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

This pull request has had no activity for 14 days and is now marked stale.

[github-actions]

Maintainer list change

Gains approval rights:

• @FrostGod

Confirm every change is intended. Anyone listed here can single-handedly satisfy OpenShell / Maintainer Approval.

[elezar]

/ok to test 613b95b

[github-actions]

Label test:e2e applied for 613b95b. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

[elezar]

Holding this until the conformance program lands, via either #5138 or its restack in #5249.

Both PRs move the conformance suites from tests/suites/conformance/tests/*.rs into a library under src/, registered with a mod line in src/lib.rs, and rewrite the suite README. After one of them merges, this PR needs to:

• move create_upload.rs into src/ and add mod create_upload; to src/lib.rs
• redo the create-upload row in the README
• recheck the test names against the new nextest naming

The three tests passed in all five conformance lanes on the current head (613b95b73), so this is a layout change only. I'll rebase once the program merges.

[elezar]

/ok-to-test 4e45045