Repository navigation
fix(server): budget SSH relays and service forwards separately - #5063
Conversation
Open service forwards no longer block SSH. Both per-sandbox caps are configurable and the limit error names the exhausted budget. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@krishicks @matthewgrossman could you please triage #4472 so the issue check can pass? @drew @mrunalp PTAL, and |
|
@johntmyers @TaylorMutch could you please triage #4472 so the issue check can pass? PTAL, and |
|
/ok to test b45de0c |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. api-behavior — No explicit risk acceptance foundForwardTcp replaces the shared 20-relay sandbox ceiling with independent default ceilings of 20 SSH relays and 20 service forwards.
Review details
Advisory review; publication gates are unchanged. |
TaylorMutch
left a comment
There was a problem hiding this comment.
Reviewed the separate SSH and service-forward budgets, configuration validation, token-count rollback, and connection-guard cleanup. No actionable code faults found. Focused accounting checks and PR CI pass.
Summary
SSH relays and service forwards now have separate per-sandbox budgets, so open forwards no longer block SSH.
Related Issue
Closes #4472
Changes
max_ssh_connections_per_sandboxandmax_service_connections_per_sandboxgateway settings (default 20, minimum 1).Release Notes
SSH and service forward connections have separate per-sandbox limits, both configurable in the gateway config.
Testing
cargo fmt,cargo clippy -D warnings, and lib tests for core and server pass.Checklist