Repository navigation
test(e2e): join shared-supervisor-ha helm overlays without image-tag syntax - #5447
Conversation
…syntax Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
|
I cannot add labels on this repo. Could someone please add |
TaylorMutch
left a comment
There was a problem hiding this comment.
Reviewed d6c9a29. The refactor preserves the Helm overlay order and caller-appended values.
Ran mise run e2e:kubernetes:shared-supervisor-ha locally against this exact commit using an ephemeral k3d cluster: 21 conformance tests passed (1 intentionally skipped), and all 9 tests in the HA suite passed, including supervisor takeover without restarting sandboxes and routing through gateway/supervisor failures. The command exited 0.
Approved as a behavior-preserving task refactor. The reported scanner false positive has not been independently reproduced.
|
/ok to test d6c9a29 |
…syntax (NVIDIA#5447) Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
Closes #5448
Summary
The e2e:kubernetes:shared-supervisor-ha task colon-joins three Helm values files in one string:
…/values-high-availability.yaml:deploy/helm/…/values-supervisor-ha.yaml:deploy/…
Anything that scans for container images (grep, image-policy linters, Trivy-style tag checks) reads the middle join as
helm/openshell/ci/values-supervisor-ha.yaml:deploy. That is a path list, not an image. Splitting the join across assignments keeps the same OPENSHELL_E2E_KUBE_EXTRA_VALUES contract and --values order, and it scales if a fourth overlay is added.Changes
tasks/test.toml.OPENSHELL_E2E_KUBE_EXTRA_VALUESvalue and caller-overlay append.Testing
Verified
tasks/test.tomlstill parses andmisestill listse2e:kubernetes:shared-supervisor-ha.Checklist