Skip to content

test(e2e): join shared-supervisor-ha helm overlays without image-tag syntax - #5447

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
ChristianZaccaria:pr-2
Nov 10, 2026
Merged

TaylorMutch merged 1 commit into
NVIDIA:mainfrom
ChristianZaccaria:pr-2

Conversation

@ChristianZaccaria

@ChristianZaccaria ChristianZaccaria commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #5448

Summary

The e2e:kubernetes:shared-supervisor-ha task colon-joins three Helm values files in one string:

…/values-high-availability.yaml:deploy/helm/…/values-supervisor-ha.yaml:deploy/…

Anything that scans for container images (grep, image-policy linters, Trivy-style tag checks) reads the middle join as helm/openshell/ci/values-supervisor-ha.yaml:deploy. That is a path list, not an image. Splitting the join across assignments keeps the same OPENSHELL_E2E_KUBE_EXTRA_VALUES contract and --values order, and it scales if a fourth overlay is added.

Changes

  • Join the high-availability, supervisor-ha, and TLS overlay paths across assignments in tasks/test.toml.
  • Keep the same colon-separated OPENSHELL_E2E_KUBE_EXTRA_VALUES value and caller-overlay append.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Verified tasks/test.toml still parses and mise still lists e2e:kubernetes:shared-supervisor-ha.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

…syntax

Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ChristianZaccaria

Copy link
Copy Markdown
Contributor Author

I cannot add labels on this repo. Could someone please add area:build so review readiness can assign reviewers. This PR only changes a mise e2e task in tasks/test.toml.

@TaylorMutch TaylorMutch added the area:build Related to CI/CD and builds label Nov 10, 2026

@TaylorMutch TaylorMutch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed d6c9a29. The refactor preserves the Helm overlay order and caller-appended values.

Ran mise run e2e:kubernetes:shared-supervisor-ha locally against this exact commit using an ephemeral k3d cluster: 21 conformance tests passed (1 intentionally skipped), and all 9 tests in the HA suite passed, including supervisor takeover without restarting sandboxes and routing through gateway/supervisor failures. The command exited 0.

Approved as a behavior-preserving task refactor. The reported scanner false positive has not been independently reproduced.

@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test d6c9a29

@TaylorMutch
TaylorMutch added this pull request to the merge queue Nov 10, 2026
Merged via the queue into NVIDIA:main with commit d2192b8 Nov 10, 2026
96 of 99 checks passed
jgarciao pushed a commit to jgarciao/OpenShell that referenced this pull request Nov 11, 2026
…syntax (NVIDIA#5447)

Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Related to CI/CD and builds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: shared-supervisor-ha helm overlay list looks like an image tag

2 participants